* [PATCH] ALSA: hda: cs35l56: Fix signedness error in cs35l56_hda_posture_put()
@ 2026-02-26 11:17 Richard Fitzgerald
2026-02-26 11:43 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Richard Fitzgerald @ 2026-02-26 11:17 UTC (permalink / raw)
To: tiwai; +Cc: linux-kernel, linux-sound, patches
In cs35l56_hda_posture_put() assign ucontrol->value.integer.value[0] to
a long instead of an unsigned long. ucontrol->value.integer.value[0] is
a long.
This fixes the sparse warning:
sound/hda/codecs/side-codecs/cs35l56_hda.c:256:20: warning: unsigned value
that used to be signed checked against zero?
sound/hda/codecs/side-codecs/cs35l56_hda.c:252:29: signed value source
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 73cfbfa9caea8 ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
---
sound/hda/codecs/side-codecs/cs35l56_hda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/hda/codecs/side-codecs/cs35l56_hda.c b/sound/hda/codecs/side-codecs/cs35l56_hda.c
index cfc8de2ae499..eb66827eabf8 100644
--- a/sound/hda/codecs/side-codecs/cs35l56_hda.c
+++ b/sound/hda/codecs/side-codecs/cs35l56_hda.c
@@ -249,7 +249,7 @@ static int cs35l56_hda_posture_put(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
struct cs35l56_hda *cs35l56 = snd_kcontrol_chip(kcontrol);
- unsigned long pos = ucontrol->value.integer.value[0];
+ long pos = ucontrol->value.integer.value[0];
bool changed;
int ret;
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: hda: cs35l56: Fix signedness error in cs35l56_hda_posture_put()
2026-02-26 11:17 [PATCH] ALSA: hda: cs35l56: Fix signedness error in cs35l56_hda_posture_put() Richard Fitzgerald
@ 2026-02-26 11:43 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-02-26 11:43 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: tiwai, linux-kernel, linux-sound, patches
On Thu, 26 Feb 2026 12:17:28 +0100,
Richard Fitzgerald wrote:
>
> In cs35l56_hda_posture_put() assign ucontrol->value.integer.value[0] to
> a long instead of an unsigned long. ucontrol->value.integer.value[0] is
> a long.
>
> This fixes the sparse warning:
>
> sound/hda/codecs/side-codecs/cs35l56_hda.c:256:20: warning: unsigned value
> that used to be signed checked against zero?
> sound/hda/codecs/side-codecs/cs35l56_hda.c:252:29: signed value source
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Fixes: 73cfbfa9caea8 ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-26 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-26 11:17 [PATCH] ALSA: hda: cs35l56: Fix signedness error in cs35l56_hda_posture_put() Richard Fitzgerald
2026-02-26 11:43 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®