mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ext2: remove stale TODO about kmap
@ 2026-02-07  0:29 Milos Nikic
  2026-02-27  5:09 ` Milos Nikic
  0 siblings, 1 reply; 3+ messages in thread
From: Milos Nikic @ 2026-02-07  0:29 UTC (permalink / raw)
  To: jack; +Cc: linux-ext4, linux-kernel, Milos Nikic

The TODO comment in the file header asking to get rid of kmap() is
outdated. The code has already been converted to use the folio API
(specifically kmap_local_folio).

Remove the stale comment to reflect the current state of the code.

Signed-off-by: Milos Nikic <nikic.milos@gmail.com>
---
 fs/ext2/namei.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c
index bde617a66cec..3ab23de558fb 100644
--- a/fs/ext2/namei.c
+++ b/fs/ext2/namei.c
@@ -14,8 +14,6 @@
  *
  * The only non-static object here is ext2_dir_inode_operations.
  *
- * TODO: get rid of kmap() use, add readahead.
- *
  * Copyright (C) 1992, 1993, 1994, 1995
  * Remy Card (card@masi.ibp.fr)
  * Laboratoire MASI - Institut Blaise Pascal
-- 
2.52.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ext2: remove stale TODO about kmap
  2026-02-07  0:29 [PATCH] ext2: remove stale TODO about kmap Milos Nikic
@ 2026-02-27  5:09 ` Milos Nikic
  2026-02-27 11:14   ` Jan Kara
  0 siblings, 1 reply; 3+ messages in thread
From: Milos Nikic @ 2026-02-27  5:09 UTC (permalink / raw)
  To: nikic.milos; +Cc: jack, linux-ext4, linux-kernel

Hi Jan,

Just a friendly ping on this patch now that a few weeks have passed.
Let me know if you need any changes!

Thanks,
Milos

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ext2: remove stale TODO about kmap
  2026-02-27  5:09 ` Milos Nikic
@ 2026-02-27 11:14   ` Jan Kara
  0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2026-02-27 11:14 UTC (permalink / raw)
  To: Milos Nikic; +Cc: jack, linux-ext4, linux-kernel

Hi!

On Thu 26-02-26 21:09:34, Milos Nikic wrote:
> Just a friendly ping on this patch now that a few weeks have passed.
> Let me know if you need any changes!

Thanks for reminder. I usually merge only important fixes while the merge
window is open (as I want to base a branch with non-critical stuff on top
of rc1 or later). But now is the right time so I've picked up this patch to
my tree. Thanks!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-27 11:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-07  0:29 [PATCH] ext2: remove stale TODO about kmap Milos Nikic
2026-02-27  5:09 ` Milos Nikic
2026-02-27 11:14   ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®