From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers
Date: Sat, 28 Feb 2026 11:37:15 +0000 [thread overview]
Message-ID: <20260228113715.3d0c4312@jic23-huawei> (raw)
In-Reply-To: <aaGyUMNzk9cNC5LG@ashevche-desk.local>
On Fri, 27 Feb 2026 17:03:44 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Fri, Feb 27, 2026 at 04:01:29PM +0200, Antoniu Miclaus wrote:
> > Use dev_err_probe() consistently in the probe path of several ADI IIO
> > drivers. This simplifies error handling and ensures proper logging of
> > deferred probes.
> >
> > Each driver is updated in two patches: first introducing a local
> > struct device *dev variable alongside the existing spi variable to
> > replace &spi->dev references in non-error paths, then converting
> > dev_err() error paths to use dev_err_probe().
> >
> > Drivers updated:
> > - adrf6780
> > - admv1014
> > - admv1013
> > - adf4377
> > - ad7293
> > - admv8818
>
> > Changes in v4:
> > - Split each driver update back into two separate patches: one for
> > introducing the struct device variable and one for the dev_err_probe()
> > conversion. No lines are edited twice cross patch pairs, error-only
> > functions get dev introduced in the "use dev_err_probe" commit.
>
> Thanks, I briefly looked and it looks fine to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Applied with a minor tweak to add () after dev_err_probe in the
the patch titles.
I like to encourage that way of indicating functions and don't want too many
patches not doing that in the tree. You had the () in the more detailed
descriptions so this is a really minor thing.
Thanks,
Jonathan
>
prev parent reply other threads:[~2026-02-28 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 14:01 Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 01/12] iio: frequency: adrf6780: add dev variable Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 02/12] iio: frequency: adrf6780: use dev_err_probe Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 03/12] iio: frequency: admv1014: add dev variable Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 04/12] iio: frequency: admv1014: use dev_err_probe Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 05/12] iio: frequency: admv1013: add dev variable Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 06/12] iio: frequency: admv1013: use dev_err_probe Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 07/12] iio: frequency: adf4377: add dev variable Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 08/12] iio: frequency: adf4377: use dev_err_probe Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 09/12] iio: dac: ad7293: add dev variable Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 10/12] iio: dac: ad7293: use dev_err_probe Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 11/12] iio: filter: admv8818: add dev variable Antoniu Miclaus
2026-02-27 14:01 ` [PATCH v4 12/12] iio: filter: admv8818: use dev_err_probe Antoniu Miclaus
2026-02-27 15:03 ` [PATCH v4 00/12] iio: use dev_err_probe in probe path for ADI drivers Andy Shevchenko
2026-02-28 11:37 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228113715.3d0c4312@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®