* [PATCH] media: ti: vpe: Add missing v4l2_device_unregister in vip_remove()
@ 2026-03-01 13:39 Felix Gu
2026-03-03 9:17 ` Yemike Abhilash Chandra
0 siblings, 1 reply; 2+ messages in thread
From: Felix Gu @ 2026-03-01 13:39 UTC (permalink / raw)
To: Yemike Abhilash Chandra, Mauro Carvalho Chehab, Benoit Parrot,
Hans Verkuil, Dale Farnsworth, Sukrut Bellary
Cc: linux-media, linux-kernel, Felix Gu
The v4l2_device is registered during probe but was not being unregistered
during remove. Add the missing v4l2_device_unregister() call to properly
clean up resources.
Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/media/platform/ti/vpe/vip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/ti/vpe/vip.c
index a4b616a5ece7..0e91e87bda9b 100644
--- a/drivers/media/platform/ti/vpe/vip.c
+++ b/drivers/media/platform/ti/vpe/vip.c
@@ -3641,6 +3641,7 @@ static void vip_remove(struct platform_device *pdev)
}
v4l2_ctrl_handler_free(&shared->ctrl_handler);
+ v4l2_device_unregister(&shared->v4l2_dev);
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260301-vip-c6e932239447
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: ti: vpe: Add missing v4l2_device_unregister in vip_remove()
2026-03-01 13:39 [PATCH] media: ti: vpe: Add missing v4l2_device_unregister in vip_remove() Felix Gu
@ 2026-03-03 9:17 ` Yemike Abhilash Chandra
0 siblings, 0 replies; 2+ messages in thread
From: Yemike Abhilash Chandra @ 2026-03-03 9:17 UTC (permalink / raw)
To: Felix Gu, Mauro Carvalho Chehab, Benoit Parrot, Hans Verkuil,
Dale Farnsworth, Sukrut Bellary
Cc: linux-media, linux-kernel
On 01/03/26 19:09, Felix Gu wrote:
> The v4l2_device is registered during probe but was not being unregistered
> during remove. Add the missing v4l2_device_unregister() call to properly
> clean up resources.
>
> Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> drivers/media/platform/ti/vpe/vip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/ti/vpe/vip.c
> index a4b616a5ece7..0e91e87bda9b 100644
> --- a/drivers/media/platform/ti/vpe/vip.c
> +++ b/drivers/media/platform/ti/vpe/vip.c
> @@ -3641,6 +3641,7 @@ static void vip_remove(struct platform_device *pdev)
> }
>
> v4l2_ctrl_handler_free(&shared->ctrl_handler);
> + v4l2_device_unregister(&shared->v4l2_dev);
>
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
>
> ---
> base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
> change-id: 20260301-vip-c6e932239447
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-03 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-01 13:39 [PATCH] media: ti: vpe: Add missing v4l2_device_unregister in vip_remove() Felix Gu
2026-03-03 9:17 ` Yemike Abhilash Chandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®