From: soolaugust@gmail.com
To: jstultz@google.com
Cc: kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, zhidao su <suzhidao@xiaomi.com>
Subject: Re: [PATCH] sched/proxy_exec: Optimize proxy_tag_curr() pushable removal
Date: Wed, 4 Mar 2026 13:33:50 +0800 [thread overview]
Message-ID: <20260304053350.554922-1-soolaugust@gmail.com> (raw)
In-Reply-To: <CANDhNCoP9CsU1ODexyC8mFj59Dx5U1DXKpYHKcJ4M1sCTZiqgQ@mail.gmail.com>
From: zhidao su <suzhidao@xiaomi.com>
On Wed, Mar 4, 2026 at 10:28 AM John Stultz <jstultz@google.com> wrote:
> Yeah, I agree we should use a sched_class-> method rather then doing
> a big conditional tree.
>
> Oh hmm, good catch! So I think you're right that right now we're
> leaning on the owner to be run without a donor before we return it
> to the pushable list, which isn't great.
>
> I'll take a swing at addressing this (along with your other feedback
> - this year has been hectic and I've only just now finally managed
> to get back to proxy-exec upstreaming efforts!) for v25.
Understood, and thanks to both of you for the thorough review.
The sched_class->proxy_tag_curr() direction makes sense -- it avoids
the conditional tree and keeps each class's pushable logic self-
contained. And the missing proxy_untag_current() is a real gap I
had not considered; good to know it will be addressed in v25.
I'll drop this RFC and wait for v25. Looking forward to it.
next prev parent reply other threads:[~2026-03-04 5:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 11:57 soolaugust
2026-03-03 15:40 ` K Prateek Nayak
2026-03-04 2:28 ` John Stultz
2026-03-04 5:33 ` soolaugust [this message]
2026-03-04 5:47 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304053350.554922-1-soolaugust@gmail.com \
--to=soolaugust@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=suzhidao@xiaomi.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®