mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joonwon Kang <joonwonkang@google.com>
To: gregkh@linuxfoundation.org
Cc: jassisinghbrar@gmail.com, joonwonkang@google.com,
	 linux-kernel@vger.kernel.org, sashal@kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] mailbox: Prevent out-of-bounds access in of_mbox_index_xlate()
Date: Wed,  4 Mar 2026 11:01:17 +0000	[thread overview]
Message-ID: <20260304110117.3317293-1-joonwonkang@google.com> (raw)
In-Reply-To: <2026030417-shudder-value-27ca@gregkh>

>> [ Upstream commit fcd7f96c783626c07ee3ed75fa3739a8a2052310 ]
>> 
>> Although it is guided that `#mbox-cells` must be at least 1, there are
>> many instances of `#mbox-cells = <0>;` in the device tree. If that is
>> the case and the corresponding mailbox controller does not provide
>> `fw_xlate` and of_xlate` function pointers, `of_mbox_index_xlate()` will
>> be used by default and out-of-bounds accesses could occur due to lack of
>> bounds check in that function.
>> 
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Joonwon Kang <joonwonkang@google.com>
>> Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
>> [ changed sp->nargs to sp->args_count in the code and
>> fw_mbox_index_xlate() to of_mbox_index_xlate() in the commit message. ]
>> Signed-off-by: Joonwon Kang <joonwonkang@google.com>
>> ---
>>  drivers/mailbox/mailbox.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>
>What kernel tree(s) is this for?

Sorry, please ignore this patch. I have specified the proper kernel tree
in other patches.

Thanks.

      reply	other threads:[~2026-03-04 11:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  7:30 Joonwon Kang
2026-03-04  9:10 ` Greg KH
2026-03-04 11:01   ` Joonwon Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260304110117.3317293-1-joonwonkang@google.com \
    --to=joonwonkang@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®