* Bug: get_maintainer: another bug: GitAuthor and Bad divisor in main::vcs_assign: 0
@ 2026-03-04 5:36 Askar Safin
2026-03-04 6:00 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Askar Safin @ 2026-03-04 5:36 UTC (permalink / raw)
To: joe; +Cc: linux-kernel
Hi. I found a bug in get_maintainer.pl .
This bug is similar to previous one
( https://lore.kernel.org/lkml/20260222161826.2858606-1-safinaskar@gmail.com/ ),
but, in my opinion, is distinct.
Steps to reproduce:
==== begin ====
Perform full clone of git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git , then:
d-user@comp:/tmp/LINUX2$ cd linux
d-user@comp:/tmp/LINUX2/linux$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
d-user@comp:/tmp/LINUX2/linux$ git branch foo
d-user@comp:/tmp/LINUX2/linux$ git switch foo
Switched to branch 'foo'
d-user@comp:/tmp/LINUX2/linux$ echo a >> usr/default_cpio_list
d-user@comp:/tmp/LINUX2/linux$ GIT_COMMITTER_EMAIL='safinaskar@gmail.com' git commit -a -m bar --author='Askar Safin <safinaskar@gmail.com>'
[foo 88140488e43c] bar
1 file changed, 1 insertion(+)
d-user@comp:/tmp/LINUX2/linux$ scripts/get_maintainer.pl --no-rolestats --no-multiline -f usr/default_cpio_list
Bad divisor in main::vcs_assign: 0
Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nsc@kernel.org>, "GitAuthor: Askar Safin" <safinaskar@gmail.com>, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
==== end ====
I see two problems here. First, I see message "Bad divisor in main::vcs_assign: 0".
Note that this time this is full clone of Linux.
Second, I see this weird "GitAuthor" string. I don't like this.
I intentionally pass "--no-rolestats --no-multiline" to make sure that
I can copy-paste output to "To" field of a mail. But this "GitAuthor"
means that I should manually edit the output. This prevents
automation.
--
Askar Safin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: get_maintainer: another bug: GitAuthor and Bad divisor in main::vcs_assign: 0
2026-03-04 5:36 Bug: get_maintainer: another bug: GitAuthor and Bad divisor in main::vcs_assign: 0 Askar Safin
@ 2026-03-04 6:00 ` Joe Perches
2026-03-04 22:37 ` Askar Safin
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2026-03-04 6:00 UTC (permalink / raw)
To: Askar Safin; +Cc: linux-kernel
On Wed, 2026-03-04 at 08:36 +0300, Askar Safin wrote:
> ```
> Hi. I found a bug in get_maintainer.pl .
>
> This bug is similar to previous one
> ( [https://lore.kernel.org/lkml/20260222161826.2858606-1-safinaskar@gmail.com/](https://lore.kernel.org/lkml/20260222161826.2858606-1-safinaskar@gmail.com/) ),
> but, in my opinion, is distinct.
[]
> d-user@comp:/tmp/LINUX2/linux$ scripts/get_maintainer.pl --no-rolestats --no-multiline -f usr/default_cpio_list
> Bad divisor in main::vcs_assign: 0
> Nathan Chancellor <[nathan@kernel.org](mailto:nathan@kernel.org)>, Nicolas Schier <[nsc@kernel.org](mailto:nsc@kernel.org)>, "GitAuthor: Askar Safin" <[safinaskar@gmail.com](mailto:safinaskar@gmail.com)>, [linux-kbuild@vger.kernel.org](mailto:linux-kbuild@vger.kernel.org), [linux-kernel@vger.kernel.org](mailto:linux-kernel@vger.kernel.org)
Your commit does not have a Signed-off-by: line
so it defaults to the gitauthor.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: get_maintainer: another bug: GitAuthor and Bad divisor in main::vcs_assign: 0
2026-03-04 6:00 ` Joe Perches
@ 2026-03-04 22:37 ` Askar Safin
0 siblings, 0 replies; 3+ messages in thread
From: Askar Safin @ 2026-03-04 22:37 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, safinaskar
Joe Perches <joe@perches.com>:
> Your commit does not have a Signed-off-by: line
> so it defaults to the gitauthor.
Yes, adding Signed-Off-by indeed removed both "Bad divisor" and "GitAuthor".
Thank you!
But I still don't like this. I usually don't add Signed-Off-by when
doing local development. I add it when sending using
"git format-patch --signoff".
Also, I still believe message "Bad divisor in main::vcs_assign: 0" is
too cryptic. Please, replace it with something else.
--
Askar Safin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-04 22:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-04 5:36 Bug: get_maintainer: another bug: GitAuthor and Bad divisor in main::vcs_assign: 0 Askar Safin
2026-03-04 6:00 ` Joe Perches
2026-03-04 22:37 ` Askar Safin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®