* [PATCH V2] PCI: imx6: Change imx_pcie_deassert_core_reset() to return void
@ 2026-03-06 2:12 Sherry Sun
2026-03-06 3:09 ` Hongxing Zhu
2026-03-26 17:10 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Sherry Sun @ 2026-03-06 2:12 UTC (permalink / raw)
To: hongxing.zhu, l.stach, Frank.Li, bhelgaas, lpieralisi,
kwilczynski, mani, robh, krzk+dt, s.hauer, festevam
Cc: imx, kernel, linux-pci, linux-arm-kernel, linux-kernel
The function imx_pcie_deassert_core_reset() always returns 0 and the
return value is not used meaningfully by its callers.
Change the return type from int to void to simplify the code and
remove unnecessary error handling paths. No functional change intended.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
Changes in V2:
1. Remove the Fixes tag.
2. Add Reviewed-by tag.
---
drivers/pci/controller/dwc/pci-imx6.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 81a7093494c8..ba6e7c7ee625 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -906,7 +906,7 @@ static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie)
gpiod_set_value_cansleep(imx_pcie->reset_gpiod, 1);
}
-static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)
+static void imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)
{
reset_control_deassert(imx_pcie->pciephy_reset);
@@ -920,8 +920,6 @@ static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)
/* Wait for 100ms after PERST# deassertion (PCIe r5.0, 6.6.1) */
msleep(100);
}
-
- return 0;
}
static int imx_pcie_wait_for_speed_change(struct imx_pcie *imx_pcie)
@@ -1292,11 +1290,7 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp)
/* Make sure that PCIe LTSSM is cleared */
imx_pcie_ltssm_disable(dev);
- ret = imx_pcie_deassert_core_reset(imx_pcie);
- if (ret < 0) {
- dev_err(dev, "pcie deassert core reset failed: %d\n", ret);
- goto err_phy_off;
- }
+ imx_pcie_deassert_core_reset(imx_pcie);
if (imx_pcie->drvdata->wait_pll_lock) {
ret = imx_pcie->drvdata->wait_pll_lock(imx_pcie);
@@ -1613,9 +1607,7 @@ static int imx_pcie_resume_noirq(struct device *dev)
ret = imx_pcie->drvdata->enable_ref_clk(imx_pcie, true);
if (ret)
return ret;
- ret = imx_pcie_deassert_core_reset(imx_pcie);
- if (ret)
- return ret;
+ imx_pcie_deassert_core_reset(imx_pcie);
/*
* Using PCIE_TEST_PD seems to disable MSI and powers down the
--
2.37.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH V2] PCI: imx6: Change imx_pcie_deassert_core_reset() to return void
2026-03-06 2:12 [PATCH V2] PCI: imx6: Change imx_pcie_deassert_core_reset() to return void Sherry Sun
@ 2026-03-06 3:09 ` Hongxing Zhu
2026-03-26 17:10 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Hongxing Zhu @ 2026-03-06 3:09 UTC (permalink / raw)
To: Sherry Sun, l.stach, Frank Li, bhelgaas, lpieralisi, kwilczynski,
mani, robh, krzk+dt, s.hauer, festevam
Cc: imx, kernel, linux-pci, linux-arm-kernel, linux-kernel
> -----Original Message-----
> From: Sherry Sun <sherry.sun@nxp.com>
> Sent: 2026年3月6日 10:13
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; l.stach@pengutronix.de; Frank
> Li <frank.li@nxp.com>; bhelgaas@google.com; lpieralisi@kernel.org;
> kwilczynski@kernel.org; mani@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com
> Cc: imx@lists.linux.dev; kernel@pengutronix.de; linux-pci@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [PATCH V2] PCI: imx6: Change imx_pcie_deassert_core_reset() to
> return void
>
> The function imx_pcie_deassert_core_reset() always returns 0 and the
> return value is not used meaningfully by its callers.
>
> Change the return type from int to void to simplify the code and remove
> unnecessary error handling paths. No functional change intended.
>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Best Regards
Richard Zhu
> ---
> Changes in V2:
> 1. Remove the Fixes tag.
> 2. Add Reviewed-by tag.
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 81a7093494c8..ba6e7c7ee625 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -906,7 +906,7 @@ static void imx_pcie_assert_core_reset(struct
> imx_pcie *imx_pcie)
> gpiod_set_value_cansleep(imx_pcie->reset_gpiod, 1); }
>
> -static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)
> +static void imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)
> {
> reset_control_deassert(imx_pcie->pciephy_reset);
>
> @@ -920,8 +920,6 @@ static int imx_pcie_deassert_core_reset(struct
> imx_pcie *imx_pcie)
> /* Wait for 100ms after PERST# deassertion (PCIe r5.0, 6.6.1) */
> msleep(100);
> }
> -
> - return 0;
> }
>
> static int imx_pcie_wait_for_speed_change(struct imx_pcie *imx_pcie) @@
> -1292,11 +1290,7 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp)
> /* Make sure that PCIe LTSSM is cleared */
> imx_pcie_ltssm_disable(dev);
>
> - ret = imx_pcie_deassert_core_reset(imx_pcie);
> - if (ret < 0) {
> - dev_err(dev, "pcie deassert core reset failed: %d\n", ret);
> - goto err_phy_off;
> - }
> + imx_pcie_deassert_core_reset(imx_pcie);
>
> if (imx_pcie->drvdata->wait_pll_lock) {
> ret = imx_pcie->drvdata->wait_pll_lock(imx_pcie);
> @@ -1613,9 +1607,7 @@ static int imx_pcie_resume_noirq(struct device
> *dev)
> ret = imx_pcie->drvdata->enable_ref_clk(imx_pcie, true);
> if (ret)
> return ret;
> - ret = imx_pcie_deassert_core_reset(imx_pcie);
> - if (ret)
> - return ret;
> + imx_pcie_deassert_core_reset(imx_pcie);
>
> /*
> * Using PCIE_TEST_PD seems to disable MSI and powers down the
> --
> 2.37.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2] PCI: imx6: Change imx_pcie_deassert_core_reset() to return void
2026-03-06 2:12 [PATCH V2] PCI: imx6: Change imx_pcie_deassert_core_reset() to return void Sherry Sun
2026-03-06 3:09 ` Hongxing Zhu
@ 2026-03-26 17:10 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2026-03-26 17:10 UTC (permalink / raw)
To: hongxing.zhu, l.stach, Frank.Li, bhelgaas, lpieralisi,
kwilczynski, robh, krzk+dt, s.hauer, festevam, Sherry Sun
Cc: imx, kernel, linux-pci, linux-arm-kernel, linux-kernel
On Fri, 06 Mar 2026 10:12:47 +0800, Sherry Sun wrote:
> The function imx_pcie_deassert_core_reset() always returns 0 and the
> return value is not used meaningfully by its callers.
>
> Change the return type from int to void to simplify the code and
> remove unnecessary error handling paths. No functional change intended.
>
>
> [...]
Applied, thanks!
[1/1] PCI: imx6: Change imx_pcie_deassert_core_reset() to return void
commit: 192b8a1bf81c17852b6cf540c95b0a3bcc9c58c4
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-26 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-06 2:12 [PATCH V2] PCI: imx6: Change imx_pcie_deassert_core_reset() to return void Sherry Sun
2026-03-06 3:09 ` Hongxing Zhu
2026-03-26 17:10 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®