From: Steven Rostedt <rostedt@goodmis.org>
To: Joseph Salisbury <joseph.salisbury@oracle.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/isolation: avoid reading past string in isolcpus parser
Date: Mon, 9 Mar 2026 18:09:01 -0400 [thread overview]
Message-ID: <20260309180901.4e4b8cd3@gandalf.local.home> (raw)
In-Reply-To: <20260309220216.198478-1-joseph.salisbury@oracle.com>
On Mon, 9 Mar 2026 18:02:16 -0400
Joseph Salisbury <joseph.salisbury@oracle.com> wrote:
> The function housekeeping_isolcpus_setup() advanced the parser pointer
> unconditionally after unknown flags.
>
> For an argument like 'isolcpus=unknownflag', with no trailing
> comma, this can move the pointer past the terminating NUL, and
> the next loop test reads out of bounds.
>
> Reproducer:
> isolcpus=unknownflag
>
> Advance only when the parser is not already at the terminating NUL,
> preserving existing parsing semantics while avoiding the invalid read.
>
> Fixes: 3662daf02350 ("sched/isolation: Allow "isolcpus=" to skip unknown sub-parameters")
> Cc: stable@vger.kernel.org
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Assisted-by: Codex:GPT-5
> Signed-off-by: Joseph Salisbury <joseph.salisbury@oracle.com>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
prev parent reply other threads:[~2026-03-09 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 22:02 Joseph Salisbury
2026-03-09 22:09 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309180901.4e4b8cd3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joseph.salisbury@oracle.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®