* [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
@ 2026-03-10 6:35 Chancel Liu
2026-03-10 15:10 ` Frank Li
2026-03-11 8:20 ` Krzysztof Kozlowski
0 siblings, 2 replies; 7+ messages in thread
From: Chancel Liu @ 2026-03-10 6:35 UTC (permalink / raw)
To: lgirdwood, broonie, robh, krzk+dt, conor+dt, Frank.Li,
shengjiu.wang, s.hauer, kernel, festevam, linux-sound,
devicetree, imx, linux-arm-kernel, linux-kernel
The imx-card machine driver originally supported only codecs operating
in i2s or dsp_b formats. This machine driver can support CS42448 codec
and this codec typically uses dsp_a for its TDM interface. Therefore,
dsp_a format support is required for describing such sound cards in DT.
Update DT bindings to include "dsp_a" in the list of supported DAI
formats.
Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
index 3c75c8c78987..5c08289346c0 100644
--- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
+++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
@@ -36,6 +36,7 @@ patternProperties:
items:
enum:
- i2s
+ - dsp_a
- dsp_b
dai-tdm-slot-num:
--
2.50.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
2026-03-10 6:35 [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format Chancel Liu
@ 2026-03-10 15:10 ` Frank Li
2026-03-25 7:52 ` Chancel Liu
2026-03-11 8:20 ` Krzysztof Kozlowski
1 sibling, 1 reply; 7+ messages in thread
From: Frank Li @ 2026-03-10 15:10 UTC (permalink / raw)
To: Chancel Liu
Cc: lgirdwood, broonie, robh, krzk+dt, conor+dt, shengjiu.wang,
s.hauer, kernel, festevam, linux-sound, devicetree, imx,
linux-arm-kernel, linux-kernel
On Tue, Mar 10, 2026 at 03:35:22PM +0900, Chancel Liu wrote:
> The imx-card machine driver originally supported only codecs operating
> in i2s or dsp_b formats. This machine driver can support CS42448 codec
> and this codec typically uses dsp_a for its TDM interface. Therefore,
> dsp_a format support is required for describing such sound cards in DT.
binding is descript hardware not driver. s/driver/device.
Frank
>
> Update DT bindings to include "dsp_a" in the list of supported DAI
> formats.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> index 3c75c8c78987..5c08289346c0 100644
> --- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> @@ -36,6 +36,7 @@ patternProperties:
> items:
> enum:
> - i2s
> + - dsp_a
> - dsp_b
>
> dai-tdm-slot-num:
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
2026-03-10 15:10 ` Frank Li
@ 2026-03-25 7:52 ` Chancel Liu
0 siblings, 0 replies; 7+ messages in thread
From: Chancel Liu @ 2026-03-25 7:52 UTC (permalink / raw)
To: Frank Li
Cc: lgirdwood, broonie, robh, krzk+dt, conor+dt, shengjiu.wang,
s.hauer, kernel, festevam, linux-sound, devicetree, imx,
linux-arm-kernel, linux-kernel
> > The imx-card machine driver originally supported only codecs operating
> > in i2s or dsp_b formats. This machine driver can support CS42448 codec
> > and this codec typically uses dsp_a for its TDM interface. Therefore,
> > dsp_a format support is required for describing such sound cards in DT.
>
> binding is descript hardware not driver. s/driver/device.
>
> Frank
Yes. I realize the commit message is incorrect. The intention is to
describe the codec hardware requirement. I will fix it.
Regards,
Chancel Liu
> >
> > Update DT bindings to include "dsp_a" in the list of supported DAI
> > formats.
> >
> > Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> > ---
> > Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > index 3c75c8c78987..5c08289346c0 100644
> > --- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > +++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > @@ -36,6 +36,7 @@ patternProperties:
> > items:
> > enum:
> > - i2s
> > + - dsp_a
> > - dsp_b
> >
> > dai-tdm-slot-num:
> > --
> > 2.50.1
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
2026-03-10 6:35 [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format Chancel Liu
2026-03-10 15:10 ` Frank Li
@ 2026-03-11 8:20 ` Krzysztof Kozlowski
2026-03-25 7:54 ` Chancel Liu
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-11 8:20 UTC (permalink / raw)
To: Chancel Liu
Cc: lgirdwood, broonie, robh, krzk+dt, conor+dt, Frank.Li,
shengjiu.wang, s.hauer, kernel, festevam, linux-sound,
devicetree, imx, linux-arm-kernel, linux-kernel
On Tue, Mar 10, 2026 at 03:35:22PM +0900, Chancel Liu wrote:
> The imx-card machine driver originally supported only codecs operating
> in i2s or dsp_b formats. This machine driver can support CS42448 codec
> and this codec typically uses dsp_a for its TDM interface. Therefore,
And what about other formats, which was asked last time?
> dsp_a format support is required for describing such sound cards in DT.
>
> Update DT bindings to include "dsp_a" in the list of supported DAI
> formats.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
> 1 file changed, 1 insertion(+)
Where is changelog?
Where is any explanation how you handled or not handled previous review?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
2026-03-11 8:20 ` Krzysztof Kozlowski
@ 2026-03-25 7:54 ` Chancel Liu
2026-03-25 8:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Chancel Liu @ 2026-03-25 7:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: lgirdwood, broonie, robh, krzk+dt, conor+dt, Frank Li,
shengjiu.wang, s.hauer, kernel, festevam, linux-sound,
devicetree, imx, linux-arm-kernel, linux-kernel
> > The imx-card machine driver originally supported only codecs operating
> > in i2s or dsp_b formats. This machine driver can support CS42448 codec
> > and this codec typically uses dsp_a for its TDM interface. Therefore,
>
> And what about other formats, which was asked last time?
>
The imx-card machine driver currently implements support only for
codecs with i2s and dsp_b format. The newly added CS42448 codec
requires dsp_a and that is why this patch adds dsp_a only. No other
formats are used or supported by the existing hardware covered by this
binding, so they are not included.
> > dsp_a format support is required for describing such sound cards in DT.
> >
> > Update DT bindings to include "dsp_a" in the list of supported DAI
> > formats.
> >
> > Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> > ---
> > Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> Where is changelog?
>
Sorry for this oversight.
I will add v2 change log(as well as for v3 and future versions)
for example:
changes in v2:
- Updated commit message to explain current support for i2s and dsp_b
formats and new support for dsp_a. No code changes.
> Where is any explanation how you handled or not handled previous review?
>
> Best regards,
> Krzysztof
My intention in v2 was to directly fix the issues raised by you and
other reviewers and maintainers, but I mistakenly assumed that applying
the changes in the new version was sufficient. I understand now that it
is required to explicitly describe how each review comment was handled,
even if the changes are already included in the updated patch. I will
add a clear changelog and detailed explanation in v3.
Regards,
Chancel Liu
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
2026-03-25 7:54 ` Chancel Liu
@ 2026-03-25 8:06 ` Krzysztof Kozlowski
2026-03-26 2:54 ` Chancel Liu
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-25 8:06 UTC (permalink / raw)
To: Chancel Liu
Cc: lgirdwood, broonie, robh, krzk+dt, conor+dt, Frank Li,
shengjiu.wang, s.hauer, kernel, festevam, linux-sound,
devicetree, imx, linux-arm-kernel, linux-kernel
On 25/03/2026 08:54, Chancel Liu wrote:
>>> The imx-card machine driver originally supported only codecs operating
>>> in i2s or dsp_b formats. This machine driver can support CS42448 codec
>>> and this codec typically uses dsp_a for its TDM interface. Therefore,
>>
>> And what about other formats, which was asked last time?
>>
>
> The imx-card machine driver currently implements support only for
> codecs with i2s and dsp_b format. The newly added CS42448 codec
> requires dsp_a and that is why this patch adds dsp_a only. No other
> formats are used or supported by the existing hardware covered by this
First sentence says about driver, here you speak about hardware, so
feels like you are mixing these.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
2026-03-25 8:06 ` Krzysztof Kozlowski
@ 2026-03-26 2:54 ` Chancel Liu
0 siblings, 0 replies; 7+ messages in thread
From: Chancel Liu @ 2026-03-26 2:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: lgirdwood, broonie, robh, krzk+dt, conor+dt, Frank Li,
shengjiu.wang, s.hauer, kernel, festevam, linux-sound,
devicetree, imx, linux-arm-kernel, linux-kernel
> >>> The imx-card machine driver originally supported only codecs
> >>> operating in i2s or dsp_b formats. This machine driver can support
> >>> CS42448 codec and this codec typically uses dsp_a for its TDM
> >>> interface. Therefore,
> >>
> >> And what about other formats, which was asked last time?
> >>
> >
> > The imx-card machine driver currently implements support only for
> > codecs with i2s and dsp_b format. The newly added CS42448 codec
> > requires dsp_a and that is why this patch adds dsp_a only. No other
> > formats are used or supported by the existing hardware covered by this
>
> First sentence says about driver, here you speak about hardware, so feels like
> you are mixing these.
>
> Best regards,
> Krzysztof
You're right, I should not mention the driver. What I meant is that the
existing i.MX audio sound card described by this binding use codecs
that operate in i2s or dsp_b formats.
Regards,
Chancel Liu
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-03-26 2:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-10 6:35 [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format Chancel Liu
2026-03-10 15:10 ` Frank Li
2026-03-25 7:52 ` Chancel Liu
2026-03-11 8:20 ` Krzysztof Kozlowski
2026-03-25 7:54 ` Chancel Liu
2026-03-25 8:06 ` Krzysztof Kozlowski
2026-03-26 2:54 ` Chancel Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®