* [PATCH v2] btrfs: tree-checker: fix misleading root drop_level error message
@ 2026-03-12 0:33 ZhengYuan Huang
2026-03-12 1:08 ` Qu Wenruo
0 siblings, 1 reply; 2+ messages in thread
From: ZhengYuan Huang @ 2026-03-12 0:33 UTC (permalink / raw)
To: dsterba, clm, wqu; +Cc: linux-btrfs, linux-kernel, ZhengYuan Huang
Fix tree-checker error message to report "invalid root drop_level"
instead of the misleading "invalid root level".
Fixes: 259ee7754b67 ("btrfs: tree-checker: Add ROOT_ITEM check")
Signed-off-by: ZhengYuan Huang <gality369@gmail.com>
---
[CHANGELOG]
v2:
- Split out the error message fix from the previous patch, as requested
during review.
---
fs/btrfs/tree-checker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index 1e052c3303b3..a8c568b10432 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -1256,7 +1256,7 @@ static int check_root_item(struct extent_buffer *leaf, struct btrfs_key *key,
}
if (unlikely(btrfs_root_drop_level(&ri) >= BTRFS_MAX_LEVEL)) {
generic_err(leaf, slot,
- "invalid root level, have %u expect [0, %u]",
+ "invalid root drop_level, have %u expect [0, %u]",
btrfs_root_drop_level(&ri), BTRFS_MAX_LEVEL - 1);
return -EUCLEAN;
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] btrfs: tree-checker: fix misleading root drop_level error message
2026-03-12 0:33 [PATCH v2] btrfs: tree-checker: fix misleading root drop_level error message ZhengYuan Huang
@ 2026-03-12 1:08 ` Qu Wenruo
0 siblings, 0 replies; 2+ messages in thread
From: Qu Wenruo @ 2026-03-12 1:08 UTC (permalink / raw)
To: ZhengYuan Huang, dsterba, clm; +Cc: linux-btrfs, linux-kernel
在 2026/3/12 11:03, ZhengYuan Huang 写道:
> Fix tree-checker error message to report "invalid root drop_level"
> instead of the misleading "invalid root level".
>
> Fixes: 259ee7754b67 ("btrfs: tree-checker: Add ROOT_ITEM check")
> Signed-off-by: ZhengYuan Huang <gality369@gmail.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> [CHANGELOG]
> v2:
> - Split out the error message fix from the previous patch, as requested
> during review.
> ---
> fs/btrfs/tree-checker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index 1e052c3303b3..a8c568b10432 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -1256,7 +1256,7 @@ static int check_root_item(struct extent_buffer *leaf, struct btrfs_key *key,
> }
> if (unlikely(btrfs_root_drop_level(&ri) >= BTRFS_MAX_LEVEL)) {
> generic_err(leaf, slot,
> - "invalid root level, have %u expect [0, %u]",
> + "invalid root drop_level, have %u expect [0, %u]",
> btrfs_root_drop_level(&ri), BTRFS_MAX_LEVEL - 1);
> return -EUCLEAN;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-12 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-12 0:33 [PATCH v2] btrfs: tree-checker: fix misleading root drop_level error message ZhengYuan Huang
2026-03-12 1:08 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®