From: Christoph Hellwig <hch@lst.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-tcp.h: correct kernel-doc comments
Date: Thu, 12 Mar 2026 08:03:54 +0100 [thread overview]
Message-ID: <20260312070354.GA27358@lst.de> (raw)
In-Reply-To: <20260312051431.684352-1-rdunlap@infradead.org>
On Wed, Mar 11, 2026 at 10:14:31PM -0700, Randy Dunlap wrote:
> Mark reserved fields as "private:" so that kernel-doc comments are
> not required for them.
I'm honestly not sure the kerneldoc makes any sense for an on-disk
structure that has an external specification. So insteada of these
hacks, what about just dropping the kerneldoc comment entirely?
next prev parent reply other threads:[~2026-03-12 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 5:14 Randy Dunlap
2026-03-12 7:03 ` Christoph Hellwig [this message]
2026-03-13 4:22 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312070354.GA27358@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®