From: Piyush Patle <piyushpatle228@gmail.com>
To: lee@kernel.org, broonie@kernel.org
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-mfd@vger.kernel.org
Subject: [PATCH] mfd/ASoC: WM8400: select SND_SOC_WM8400 from MFD_WM8400
Date: Mon, 16 Mar 2026 01:51:17 +0530 [thread overview]
Message-ID: <20260315202117.200641-1-piyushpatle228@gmail.com> (raw)
The MFD driver wm8400-core.c unconditionally registers a platform
device named 'wm8400-codec' via wm8400_register_codec(). The codec
driver in sound/soc/codecs/wm8400.c binds to this device by name,
but SND_SOC_WM8400 is a hidden symbol with no prompt and nothing
was selecting it in normal configurations, so the driver never built.
Fix this by adding 'select SND_SOC_WM8400' to MFD_WM8400, which
encodes the implicit dependency that already existed at runtime.
Also remove the FIXME comment that noted this gap.
Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
---
drivers/mfd/Kconfig | 1 +
sound/soc/codecs/Kconfig | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 7192c9d1d268..d931612e0468 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -2127,6 +2127,7 @@ config MFD_WM8400
select MFD_CORE
depends on I2C=y
select REGMAP_I2C
+ select SND_SOC_WM8400
help
Support for the Wolfson Microelecronics WM8400 PMIC and audio
CODEC. This driver provides common support for accessing
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index adb3fb923be3..0e912f6ec89c 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -2496,7 +2496,6 @@ config SND_SOC_WM8350
config SND_SOC_WM8400
tristate
- # FIXME nothing selects SND_SOC_WM8400??
depends on MFD_WM8400
config SND_SOC_WM8510
--
2.34.1
next reply other threads:[~2026-03-15 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 20:21 Piyush Patle [this message]
2026-03-15 23:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260315202117.200641-1-piyushpatle228@gmail.com \
--to=piyushpatle228@gmail.com \
--cc=broonie@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mfd@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®