From: Mark Brown <broonie@kernel.org>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: lee@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, linux-mfd@vger.kernel.org
Subject: Re: [PATCH] mfd/ASoC: WM8400: select SND_SOC_WM8400 from MFD_WM8400
Date: Sun, 15 Mar 2026 23:56:03 +0000 [thread overview]
Message-ID: <abdHE2O9Na4u-qDj@sirena.co.uk> (raw)
In-Reply-To: <20260315202117.200641-1-piyushpatle228@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Mon, Mar 16, 2026 at 01:51:17AM +0530, Piyush Patle wrote:
> The MFD driver wm8400-core.c unconditionally registers a platform
> device named 'wm8400-codec' via wm8400_register_codec(). The codec
> driver in sound/soc/codecs/wm8400.c binds to this device by name,
> but SND_SOC_WM8400 is a hidden symbol with no prompt and nothing
> was selecting it in normal configurations, so the driver never built.
>
> Fix this by adding 'select SND_SOC_WM8400' to MFD_WM8400, which
> encodes the implicit dependency that already existed at runtime.
> Also remove the FIXME comment that noted this gap.
This doesn't accomplish anything, the driver will do nothing unless a
sound card binds to it. This is very standard for older CODEC drivers,
the comment just shouldn't be there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-03-15 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 20:21 Piyush Patle
2026-03-15 23:56 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abdHE2O9Na4u-qDj@sirena.co.uk \
--to=broonie@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mfd@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=piyushpatle228@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®