From: Gabriele Paoloni <gpaoloni@redhat.com>
To: mani@kernel.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: gpaoloni@redhat.com, mpapini@redhat.com, dnita@qti.qualcomm.com,
rballati@qti.qualcomm.com, bijothom@qti.qualcomm.com,
wchadwic@redhat.com
Subject: [PATCH 1/2] mailbox: qcom-ipcc: amend qcom_ipcc_domain_map() to report errors
Date: Mon, 16 Mar 2026 11:26:17 +0100 [thread overview]
Message-ID: <20260316102618.7953-2-gpaoloni@redhat.com> (raw)
In-Reply-To: <20260316102618.7953-1-gpaoloni@redhat.com>
Currently qcom_ipcc_domain_map() ignores errors returned by
irq_set_chip_data() and invokes irq_set_chip_and_handler()
that in turn ignores errors returned by irq_set_chip().
This patch fixes both issues; no other functional changes
are implemented.
Signed-off-by: Gabriele Paoloni <gpaoloni@redhat.com>
---
drivers/mailbox/qcom-ipcc.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
index d957d989c0ce..c23efaaa64a1 100644
--- a/drivers/mailbox/qcom-ipcc.c
+++ b/drivers/mailbox/qcom-ipcc.c
@@ -116,12 +116,20 @@ static struct irq_chip qcom_ipcc_irq_chip = {
static int qcom_ipcc_domain_map(struct irq_domain *d, unsigned int irq,
irq_hw_number_t hw)
{
+ int ret;
struct qcom_ipcc *ipcc = d->host_data;
- irq_set_chip_and_handler(irq, &qcom_ipcc_irq_chip, handle_level_irq);
- irq_set_chip_data(irq, ipcc);
- irq_set_noprobe(irq);
+ ret = irq_set_chip(irq, &qcom_ipcc_irq_chip);
+ if (ret)
+ return ret;
+
+ irq_set_handler(irq, handle_level_irq);
+ ret = irq_set_chip_data(irq, ipcc);
+ if (ret)
+ return ret;
+
+ irq_set_noprobe(irq);
return 0;
}
--
2.48.1
next prev parent reply other threads:[~2026-03-16 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 10:26 [PATCH 0/2] mailbox: qcom-ipcc: fix error reporting paths Gabriele Paoloni
2026-03-16 10:26 ` Gabriele Paoloni [this message]
2026-03-16 11:04 ` [PATCH 1/2] mailbox: qcom-ipcc: amend qcom_ipcc_domain_map() to report errors Brian Masney
2026-03-20 11:30 ` Gabriele Paoloni
2026-03-16 10:26 ` [PATCH 2/2] mailbox: qcom-ipcc: amend qcom_ipcc_irq_fn() " Gabriele Paoloni
2026-03-16 11:05 ` Brian Masney
2026-03-20 11:25 ` Gabriele Paoloni
2026-03-17 9:13 ` Konrad Dybcio
2026-03-20 11:24 ` Gabriele Paoloni
2026-03-23 16:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316102618.7953-2-gpaoloni@redhat.com \
--to=gpaoloni@redhat.com \
--cc=bijothom@qti.qualcomm.com \
--cc=dnita@qti.qualcomm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mpapini@redhat.com \
--cc=rballati@qti.qualcomm.com \
--cc=wchadwic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®