From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Gabriele Paoloni <gpaoloni@redhat.com>,
mani@kernel.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: mpapini@redhat.com, dnita@qti.qualcomm.com,
rballati@qti.qualcomm.com, bijothom@qti.qualcomm.com,
wchadwic@redhat.com
Subject: Re: [PATCH 2/2] mailbox: qcom-ipcc: amend qcom_ipcc_irq_fn() to report errors
Date: Tue, 17 Mar 2026 10:13:15 +0100 [thread overview]
Message-ID: <384e46f3-140c-4b88-a3c8-6cbb57ecff99@oss.qualcomm.com> (raw)
In-Reply-To: <20260316102618.7953-3-gpaoloni@redhat.com>
On 3/16/26 11:26 AM, Gabriele Paoloni wrote:
> check the virq value returned by irq_find_mapping(), also
> check the return value of generic_handle_irq(); return IRQ_NONE
> if either of the checks fails.
>
> Signed-off-by: Gabriele Paoloni <gpaoloni@redhat.com>
> ---
It certainly seems useful to inspect a function's return value, however I
noticed that out of 47 in-tree callers of generic_handle_irq() within
drivers/, only one other driver (intel_lpe_audio within drm/i915) checks
that..
Similarly, many other drivers never check if irq_find_mapping() actually
succeeded. This makes me wonder how you discovered there's an issue in
the first place. Could you please add some details in the commit message?
Konrad
next prev parent reply other threads:[~2026-03-17 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 10:26 [PATCH 0/2] mailbox: qcom-ipcc: fix error reporting paths Gabriele Paoloni
2026-03-16 10:26 ` [PATCH 1/2] mailbox: qcom-ipcc: amend qcom_ipcc_domain_map() to report errors Gabriele Paoloni
2026-03-16 11:04 ` Brian Masney
2026-03-20 11:30 ` Gabriele Paoloni
2026-03-16 10:26 ` [PATCH 2/2] mailbox: qcom-ipcc: amend qcom_ipcc_irq_fn() " Gabriele Paoloni
2026-03-16 11:05 ` Brian Masney
2026-03-20 11:25 ` Gabriele Paoloni
2026-03-17 9:13 ` Konrad Dybcio [this message]
2026-03-20 11:24 ` Gabriele Paoloni
2026-03-23 16:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384e46f3-140c-4b88-a3c8-6cbb57ecff99@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=bijothom@qti.qualcomm.com \
--cc=dnita@qti.qualcomm.com \
--cc=gpaoloni@redhat.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mpapini@redhat.com \
--cc=rballati@qti.qualcomm.com \
--cc=wchadwic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®