* [PATCH v2] riscv: kvm: fix vector context allocation leak
@ 2026-03-16 15:16 Osama Abdelkader
2026-03-16 15:22 ` Andy Chiu
2026-03-27 13:16 ` Anup Patel
0 siblings, 2 replies; 3+ messages in thread
From: Osama Abdelkader @ 2026-03-16 15:16 UTC (permalink / raw)
To: Anup Patel, Atish Patra, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Alexandre Ghiti, Vincent Chen, Andy Chiu,
Greentime Hu, kvm, kvm-riscv, linux-riscv, linux-kernel
Cc: Osama Abdelkader, stable
When the second kzalloc (host_context.vector.datap) fails in
kvm_riscv_vcpu_alloc_vector_context, the first allocation
(guest_context.vector.datap) is leaked. Free it before returning.
Fixes: 0f4b82579716 ("riscv: KVM: Add vector lazy save/restore support")
Cc: stable@vger.kernel.org
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
v2:
- Add Fixes: tag
- Add Cc: stable@vger.kernel.org
---
arch/riscv/kvm/vcpu_vector.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/riscv/kvm/vcpu_vector.c b/arch/riscv/kvm/vcpu_vector.c
index 05f3cc2d8e31..5b6ad82d47be 100644
--- a/arch/riscv/kvm/vcpu_vector.c
+++ b/arch/riscv/kvm/vcpu_vector.c
@@ -80,8 +80,11 @@ int kvm_riscv_vcpu_alloc_vector_context(struct kvm_vcpu *vcpu)
return -ENOMEM;
vcpu->arch.host_context.vector.datap = kzalloc(riscv_v_vsize, GFP_KERNEL);
- if (!vcpu->arch.host_context.vector.datap)
+ if (!vcpu->arch.host_context.vector.datap) {
+ kfree(vcpu->arch.guest_context.vector.datap);
+ vcpu->arch.guest_context.vector.datap = NULL;
return -ENOMEM;
+ }
return 0;
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] riscv: kvm: fix vector context allocation leak
2026-03-16 15:16 [PATCH v2] riscv: kvm: fix vector context allocation leak Osama Abdelkader
@ 2026-03-16 15:22 ` Andy Chiu
2026-03-27 13:16 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Andy Chiu @ 2026-03-16 15:22 UTC (permalink / raw)
To: Osama Abdelkader
Cc: Anup Patel, Atish Patra, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Alexandre Ghiti, Vincent Chen, Greentime Hu, kvm,
kvm-riscv, linux-riscv, linux-kernel, stable
Hi Osama,
Thanks for spotting this,
On Mon, Mar 16, 2026 at 10:16 AM Osama Abdelkader
<osama.abdelkader@gmail.com> wrote:
>
> When the second kzalloc (host_context.vector.datap) fails in
> kvm_riscv_vcpu_alloc_vector_context, the first allocation
> (guest_context.vector.datap) is leaked. Free it before returning.
>
> Fixes: 0f4b82579716 ("riscv: KVM: Add vector lazy save/restore support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Reviewed-by: Andy Chiu <andybnac@gmail.com>
> ---
> v2:
> - Add Fixes: tag
> - Add Cc: stable@vger.kernel.org
> ---
> arch/riscv/kvm/vcpu_vector.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/vcpu_vector.c b/arch/riscv/kvm/vcpu_vector.c
> index 05f3cc2d8e31..5b6ad82d47be 100644
> --- a/arch/riscv/kvm/vcpu_vector.c
> +++ b/arch/riscv/kvm/vcpu_vector.c
> @@ -80,8 +80,11 @@ int kvm_riscv_vcpu_alloc_vector_context(struct kvm_vcpu *vcpu)
> return -ENOMEM;
>
> vcpu->arch.host_context.vector.datap = kzalloc(riscv_v_vsize, GFP_KERNEL);
> - if (!vcpu->arch.host_context.vector.datap)
> + if (!vcpu->arch.host_context.vector.datap) {
> + kfree(vcpu->arch.guest_context.vector.datap);
> + vcpu->arch.guest_context.vector.datap = NULL;
> return -ENOMEM;
> + }
>
> return 0;
> }
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] riscv: kvm: fix vector context allocation leak
2026-03-16 15:16 [PATCH v2] riscv: kvm: fix vector context allocation leak Osama Abdelkader
2026-03-16 15:22 ` Andy Chiu
@ 2026-03-27 13:16 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2026-03-27 13:16 UTC (permalink / raw)
To: Osama Abdelkader
Cc: Atish Patra, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Vincent Chen, Andy Chiu, Greentime Hu, kvm,
kvm-riscv, linux-riscv, linux-kernel, stable
On Mon, Mar 16, 2026 at 8:46 PM Osama Abdelkader
<osama.abdelkader@gmail.com> wrote:
>
> When the second kzalloc (host_context.vector.datap) fails in
> kvm_riscv_vcpu_alloc_vector_context, the first allocation
> (guest_context.vector.datap) is leaked. Free it before returning.
>
> Fixes: 0f4b82579716 ("riscv: KVM: Add vector lazy save/restore support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Queued this patch for Linux-7.1
Thanks,
Anup
> ---
> v2:
> - Add Fixes: tag
> - Add Cc: stable@vger.kernel.org
> ---
> arch/riscv/kvm/vcpu_vector.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/vcpu_vector.c b/arch/riscv/kvm/vcpu_vector.c
> index 05f3cc2d8e31..5b6ad82d47be 100644
> --- a/arch/riscv/kvm/vcpu_vector.c
> +++ b/arch/riscv/kvm/vcpu_vector.c
> @@ -80,8 +80,11 @@ int kvm_riscv_vcpu_alloc_vector_context(struct kvm_vcpu *vcpu)
> return -ENOMEM;
>
> vcpu->arch.host_context.vector.datap = kzalloc(riscv_v_vsize, GFP_KERNEL);
> - if (!vcpu->arch.host_context.vector.datap)
> + if (!vcpu->arch.host_context.vector.datap) {
> + kfree(vcpu->arch.guest_context.vector.datap);
> + vcpu->arch.guest_context.vector.datap = NULL;
> return -ENOMEM;
> + }
>
> return 0;
> }
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-27 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-16 15:16 [PATCH v2] riscv: kvm: fix vector context allocation leak Osama Abdelkader
2026-03-16 15:22 ` Andy Chiu
2026-03-27 13:16 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®