Re: [PATCH v2 1/2] dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver bindings

[Krzysztof Kozlowski <krzk@kernel.org>]

On Tue, Mar 17, 2026 at 12:23:07AM -0500, Aaron Kling wrote:
> The Chip Wealth Technology CH13726A display driver is a single chip
> solution for AMOLED using MIPI-DSI. This is used for the AYN Thor bottom
> panel.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Also drop all references to "display driver", even if you meant hardware
thing.  Driver in hardware is suitable only to motors, haptics and LEDs,
but not to displays. AMOLED driver is fine, display driver too confusing.


> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  .../display/panel/chipwealth,ch13726a.yaml         | 66 ++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..b490c6757bb98c0752ded78b8fea3aaec853c7b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/chipwealth,ch13726a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chip Wealth Technology CH13726A display driver
> +
> +maintainers:
> +  - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +description:
> +  Chip Wealth Technology CH13726A is a single-chip solution
> +  for AMOLED connected using a MIPI-DSI video interface.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: ayntec,thor-panel-bottom

Why compatible is completely different than commit msg, description and
title are saying?

> +
> +  port: true

This goes before reset-gpios

> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  vdd-supply: true
> +  vddio-supply: true
> +  vdd1v2-supply: true
> +  avdd-supply: true
> +
> +  reset-gpios: true
> +

Drop blank line here (it is port+reset-gpios+rotation in three lines).


> +  rotation: true
> +

Best regards,
Krzysztof