mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: fix line length warning
@ 2026-03-17 16:59 Andrea Poldi
  2026-03-17 17:37 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Andrea Poldi @ 2026-03-17 16:59 UTC (permalink / raw)
  To: gregkh
  Cc: daniel.baluta, simona.toaca, d-gole, m-chawdhry, Andrea Poldi,
	Khushal Chitturi, Minu Jin, Archit Anant, Andy Shevchenko,
	Kees Cook, linux-staging, linux-kernel

Break a long function call across two lines in order to make code
easier to read and also comply with the Linux coding style.

Problem was found using checkpatch.pl tool.

Signed-off-by: Andrea Poldi <andrea@riposetti.com>
---

Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 8cd2fdbe417d..c1185c25ed36 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1769,7 +1769,8 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
 		rtw_free_assoc_resources(padapter, 1);
 		break;
 	case C2H_WK_CID:
-		rtw_hal_set_hwreg_with_buf(padapter, HW_VAR_C2H_HANDLE, pdrvextra_cmd->pbuf, pdrvextra_cmd->size);
+		rtw_hal_set_hwreg_with_buf(padapter, HW_VAR_C2H_HANDLE,
+					   pdrvextra_cmd->pbuf, pdrvextra_cmd->size);
 		break;
 	case DM_RA_MSK_WK_CID:
 		rtw_dm_ra_mask_hdl(padapter, (struct sta_info *)pdrvextra_cmd->pbuf);
-- 
2.50.1 (Apple Git-155)



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8723bs: fix line length warning
  2026-03-17 16:59 [PATCH] staging: rtl8723bs: fix line length warning Andrea Poldi
@ 2026-03-17 17:37 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-03-17 17:37 UTC (permalink / raw)
  To: Andrea Poldi
  Cc: gregkh, daniel.baluta, simona.toaca, d-gole, m-chawdhry,
	Khushal Chitturi, Minu Jin, Archit Anant, Kees Cook,
	linux-staging, linux-kernel

On Tue, Mar 17, 2026 at 04:59:40PM +0000, Andrea Poldi wrote:
> Break a long function call across two lines in order to make code
> easier to read and also comply with the Linux coding style.
> 
> Problem was found using checkpatch.pl tool.

I can't believe there is only a single place in this entire driver like this.
Personally I consider this kind of changes useless unless they are coupled
with something real. But since it's staging, I'm not NAKing it. Up to Greg
and others on what to do with this patch.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-17 17:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-17 16:59 [PATCH] staging: rtl8723bs: fix line length warning Andrea Poldi
2026-03-17 17:37 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®