From: Christian Brauner <brauner@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Ian Kent <raven@themaw.net>,
autofs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] autofs: replace manual symlink buffer allocation in autofs_dir_symlink
Date: Wed, 18 Mar 2026 10:56:34 +0100 [thread overview]
Message-ID: <20260318-abheben-outen-81fc6549c319@brauner> (raw)
In-Reply-To: <20260318001219.2354-3-thorsten.blum@linux.dev>
On Wed, Mar 18, 2026 at 01:12:21AM +0100, Thorsten Blum wrote:
> The symlink name was previously duplicated using an explicit kmalloc()
> followed by strcpy(), which is deprecated [1]. Replace this open-coded
> string duplication with kstrdup(), which allocates and copies the
> symlink name with a single helper function.
>
> Remove the local variable 'size' and set 'i_size' directly using
> strlen(cp), which is equivalent to the previous value of 'size'.
>
> This simplifies the code, uses common string-handling helpers, and
> removes the deprecated use of strcpy().
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
> Acked-by: Ian Kent <raven@themaw.net>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
Ideally always Cc fsdevel. This way the tooling sees it right away.
next prev parent reply other threads:[~2026-03-18 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 0:12 Thorsten Blum
2026-03-18 9:56 ` Christian Brauner
2026-03-18 9:56 ` Christian Brauner [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-27 1:36 Thorsten Blum
2026-01-27 2:14 ` Ian Kent
2026-02-22 21:22 ` Thorsten Blum
2026-01-05 12:43 Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318-abheben-outen-81fc6549c319@brauner \
--to=brauner@kernel.org \
--cc=autofs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®