From: Thorsten Blum <thorsten.blum@linux.dev>
To: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH RESEND] autofs: replace manual symlink buffer allocation in autofs_dir_symlink
Date: Sun, 22 Feb 2026 22:22:01 +0100 [thread overview]
Message-ID: <5F120295-FC54-49A8-8B92-870EAEB0A319@linux.dev> (raw)
In-Reply-To: <6b4c95df-1005-4f8d-a350-c4bf3769228c@themaw.net>
On 27. Jan 2026, at 03:14, Ian Kent wrote:
> On 27/1/26 09:36, Thorsten Blum wrote:
>> The symlink name was previously duplicated using an explicit kmalloc()
>> followed by strcpy(), which is deprecated [1]. Replace this open-coded
>> string duplication with kstrdup(), which allocates and copies the
>> symlink name with a single helper function.
>>
>> Remove the local variable 'size' and set 'i_size' directly using
>> strlen(cp), which is equivalent to the previous value of 'size'.
>>
>> This simplifies the code, uses common string-handling helpers, and
>> removes the deprecated use of strcpy().
>>
>> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>> ---
>> fs/autofs/root.c | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> [...]
>
> Looks fine to me.
>
> Acked by: Ian Kent <raven@themaw.net>
Your tag is missing a hyphen and tools like b4 don't recognize it like
this. Correct would be:
Acked-by: Ian Kent <raven@themaw.net>
> Christian, is there anything else I need to do for this?
Thanks,
Thorsten
next prev parent reply other threads:[~2026-02-22 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 1:36 Thorsten Blum
2026-01-27 2:14 ` Ian Kent
2026-02-22 21:22 ` Thorsten Blum [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-18 0:12 Thorsten Blum
2026-03-18 9:56 ` Christian Brauner
2026-03-18 9:56 ` Christian Brauner
2026-01-05 12:43 Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F120295-FC54-49A8-8B92-870EAEB0A319@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=autofs@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®