[PATCH] ktest: Store failure logs also in fatal paths

[PATCH] ktest: Store failure logs also in fatal paths

[Ricardo B. Marlière]

STORE_FAILURES was only saved from fail(), so paths that reached dodie()
could exit without preserving failure logs.

That includes fatal hook paths such as:

  POST_BUILD_DIE = 1

and ordinary failures when:

  DIE_ON_FAILURE = 1

Call save_logs("fail", ...) from dodie() too so fatal failures keep the
same STORE_FAILURES artifacts as non-fatal fail() paths.

Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
 tools/testing/ktest/ktest.pl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index de99b82d16ad..112f9ca2444b 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -1635,6 +1635,11 @@ sub dodie {
 	print " See $opt{LOG_FILE} for more info.\n";
     }
 
+    # Fatal paths bypass fail(), so STORE_FAILURES needs to be handled here.
+    if (defined($store_failures)) {
+	save_logs("fail", $store_failures);
+    }
+
     if ($email_on_error) {
 	my $name = get_test_name;
 	my $log_file;

---
base-commit: 229517449879b3ca8ca5588593cbea6a67ba0ad2
change-id: 20260318-ktest-fixes-564376c0c56f

Best regards,
-- 
Ricardo B. Marlière <rbm@suse.com>

Re: [PATCH] ktest: Store failure logs also in fatal paths

[Steven Rostedt]

On Wed, 18 Mar 2026 16:00:43 -0300
Ricardo B. Marlière <rbm@suse.com> wrote:

> STORE_FAILURES was only saved from fail(), so paths that reached dodie()
> could exit without preserving failure logs.
> 
> That includes fatal hook paths such as:
> 
>   POST_BUILD_DIE = 1
> 
> and ordinary failures when:
> 
>   DIE_ON_FAILURE = 1
> 
> Call save_logs("fail", ...) from dodie() too so fatal failures keep the
> same STORE_FAILURES artifacts as non-fatal fail() paths.
> 
> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>

Applied, pending testing.

Thanks!

-- Steve