mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Harshal Dev <harshal.dev@oss.qualcomm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	cros-qcom-dts-watchers@chromium.org,
	Eric Biggers <ebiggers@google.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Tengfei Fan <tengfei.fan@oss.qualcomm.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	David Wronek <davidwronek@gmail.com>,
	Luca Weiss <luca.weiss@fairphone.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Melody Olvera <quic_molvera@quicinc.com>,
	Alexander Koskovich <akoskovich@pm.me>
Cc: Brian Masney <bmasney@redhat.com>,
	Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
	Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Harshal Dev <harshal.dev@oss.qualcomm.com>
Subject: [PATCH v4 02/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE
Date: Mon, 23 Mar 2026 14:47:55 +0530	[thread overview]
Message-ID: <20260323-qcom_ice_power_and_clk_vote-v4-2-e36044bbdfe9@oss.qualcomm.com> (raw)
In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com>

Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver
de-coupled from the QCOM UFS driver, it explicitly votes for its required
clocks during probe. For scenarios where the 'clk_ignore_unused' flag is
not passed on the kernel command line, to avoid potential unclocked ICE
hardware register access during probe the ICE driver should additionally
vote on the 'iface' clock.
Also update the suspend and resume callbacks to handle un-voting and voting
on the 'iface' clock.

Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver")
Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
 drivers/soc/qcom/ice.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c
index b203bc685cad..bf4ab2d9e5c0 100644
--- a/drivers/soc/qcom/ice.c
+++ b/drivers/soc/qcom/ice.c
@@ -108,6 +108,7 @@ struct qcom_ice {
 	void __iomem *base;
 
 	struct clk *core_clk;
+	struct clk *iface_clk;
 	bool use_hwkm;
 	bool hwkm_init_complete;
 	u8 hwkm_version;
@@ -312,8 +313,13 @@ int qcom_ice_resume(struct qcom_ice *ice)
 
 	err = clk_prepare_enable(ice->core_clk);
 	if (err) {
-		dev_err(dev, "failed to enable core clock (%d)\n",
-			err);
+		dev_err(dev, "Failed to enable core clock: %d\n", err);
+		return err;
+	}
+
+	err = clk_prepare_enable(ice->iface_clk);
+	if (err) {
+		dev_err(dev, "Failed to enable iface clock: %d\n", err);
 		return err;
 	}
 	qcom_ice_hwkm_init(ice);
@@ -323,6 +329,7 @@ EXPORT_SYMBOL_GPL(qcom_ice_resume);
 
 int qcom_ice_suspend(struct qcom_ice *ice)
 {
+	clk_disable_unprepare(ice->iface_clk);
 	clk_disable_unprepare(ice->core_clk);
 	ice->hwkm_init_complete = false;
 
@@ -579,11 +586,17 @@ static struct qcom_ice *qcom_ice_create(struct device *dev,
 	engine->core_clk = devm_clk_get_optional_enabled(dev, "ice_core_clk");
 	if (!engine->core_clk)
 		engine->core_clk = devm_clk_get_optional_enabled(dev, "ice");
+	if (!engine->core_clk)
+		engine->core_clk = devm_clk_get_optional_enabled(dev, "core");
 	if (!engine->core_clk)
 		engine->core_clk = devm_clk_get_enabled(dev, NULL);
 	if (IS_ERR(engine->core_clk))
 		return ERR_CAST(engine->core_clk);
 
+	engine->iface_clk = devm_clk_get_optional_enabled(dev, "iface");
+	if (IS_ERR(engine->iface_clk))
+		return ERR_CAST(engine->iface_clk);
+
 	if (!qcom_ice_check_supported(engine))
 		return ERR_PTR(-EOPNOTSUPP);
 

-- 
2.34.1


  parent reply	other threads:[~2026-03-23  9:18 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  9:17 [PATCH v4 00/11] Add explicit clock vote and enable power-domain for QCOM-ICE Harshal Dev
2026-03-23  9:17 ` [PATCH v4 01/11] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk Harshal Dev
2026-03-24 10:46   ` Kuldeep Singh
2026-03-31  9:40     ` Harshal Dev
2026-04-06  8:25       ` Harshal Dev
2026-04-07  4:58       ` Kuldeep Singh
2026-04-10  5:21         ` Kuldeep Singh
2026-04-06  8:37   ` Krzysztof Kozlowski
2026-04-06  9:20     ` Harshal Dev
2026-04-06  9:45       ` Harshal Dev
2026-03-23  9:17 ` Harshal Dev [this message]
2026-03-23 12:27   ` [PATCH v4 02/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Konrad Dybcio
2026-03-24  4:48   ` Kuldeep Singh
2026-03-24 16:29   ` Manivannan Sadhasivam
2026-03-23  9:17 ` [PATCH v4 03/11] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Harshal Dev
2026-03-24  5:04   ` Kuldeep Singh
2026-03-23  9:17 ` [PATCH v4 04/11] arm64: dts: qcom: lemans: " Harshal Dev
2026-03-24 10:33   ` Kuldeep Singh
2026-03-23  9:17 ` [PATCH v4 05/11] arm64: dts: qcom: monaco: " Harshal Dev
2026-03-24 10:48   ` Kuldeep Singh
2026-03-23  9:17 ` [PATCH v4 06/11] arm64: dts: qcom: sc7180: " Harshal Dev
2026-03-24 10:48   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 07/11] arm64: dts: qcom: kodiak: " Harshal Dev
2026-03-24 10:37   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 08/11] arm64: dts: qcom: sm8450: " Harshal Dev
2026-03-24 10:38   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 09/11] arm64: dts: qcom: sm8550: " Harshal Dev
2026-03-24 10:39   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 10/11] arm64: dts: qcom: sm8650: " Harshal Dev
2026-03-24 10:39   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 11/11] arm64: dts: qcom: sm8750: " Harshal Dev
2026-03-24 10:47   ` Kuldeep Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323-qcom_ice_power_and_clk_vote-v4-2-e36044bbdfe9@oss.qualcomm.com \
    --to=harshal.dev@oss.qualcomm.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=davem@davemloft.net \
    --cc=davidwronek@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=ebiggers@google.com \
    --cc=gaurav.kashyap@oss.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=neeraj.soni@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_molvera@quicinc.com \
    --cc=robh@kernel.org \
    --cc=tengfei.fan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®