mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Harshal Dev <harshal.dev@oss.qualcomm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	cros-qcom-dts-watchers@chromium.org,
	Eric Biggers <ebiggers@google.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Tengfei Fan <tengfei.fan@oss.qualcomm.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	David Wronek <davidwronek@gmail.com>,
	Luca Weiss <luca.weiss@fairphone.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Melody Olvera <quic_molvera@quicinc.com>,
	Alexander Koskovich <akoskovich@pm.me>
Cc: Brian Masney <bmasney@redhat.com>,
	Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
	Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Harshal Dev <harshal.dev@oss.qualcomm.com>
Subject: [PATCH v4 09/11] arm64: dts: qcom: sm8550: Add power-domain and iface clk for ice node
Date: Mon, 23 Mar 2026 14:48:02 +0530	[thread overview]
Message-ID: <20260323-qcom_ice_power_and_clk_vote-v4-9-e36044bbdfe9@oss.qualcomm.com> (raw)
In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com>

Qualcomm in-line crypto engine (ICE) platform driver specifies and votes
for its own resources. Before accessing ICE hardware during probe, to
avoid potential unclocked register access issues (when clk_ignore_unused
is not passed on the kernel command line), in addition to the 'core' clock
the 'iface' clock should also be turned on by the driver. This can only be
done if the UFS_PHY_GDSC power domain is enabled. Specify both the
UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8550.

Fixes: b8630c48b43fc ("arm64: dts: qcom: sm8550: Add the Inline Crypto Engine node")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index e3f93f4f412d..473fb4748036 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2449,7 +2449,11 @@ ice: crypto@1d88000 {
 				     "qcom,inline-crypto-engine";
 			reg = <0 0x01d88000 0 0x18000>;
 
-			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
+			clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>,
+				 <&gcc GCC_UFS_PHY_AHB_CLK>;
+			clock-names = "core",
+				      "iface";
+			power-domains = <&gcc UFS_PHY_GDSC>;
 		};
 
 		tcsr_mutex: hwlock@1f40000 {

-- 
2.34.1


  parent reply	other threads:[~2026-03-23  9:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  9:17 [PATCH v4 00/11] Add explicit clock vote and enable power-domain for QCOM-ICE Harshal Dev
2026-03-23  9:17 ` [PATCH v4 01/11] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk Harshal Dev
2026-03-24 10:46   ` Kuldeep Singh
2026-03-31  9:40     ` Harshal Dev
2026-04-06  8:25       ` Harshal Dev
2026-04-07  4:58       ` Kuldeep Singh
2026-04-10  5:21         ` Kuldeep Singh
2026-04-06  8:37   ` Krzysztof Kozlowski
2026-04-06  9:20     ` Harshal Dev
2026-04-06  9:45       ` Harshal Dev
2026-03-23  9:17 ` [PATCH v4 02/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Harshal Dev
2026-03-23 12:27   ` Konrad Dybcio
2026-03-24  4:48   ` Kuldeep Singh
2026-03-24 16:29   ` Manivannan Sadhasivam
2026-03-23  9:17 ` [PATCH v4 03/11] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Harshal Dev
2026-03-24  5:04   ` Kuldeep Singh
2026-03-23  9:17 ` [PATCH v4 04/11] arm64: dts: qcom: lemans: " Harshal Dev
2026-03-24 10:33   ` Kuldeep Singh
2026-03-23  9:17 ` [PATCH v4 05/11] arm64: dts: qcom: monaco: " Harshal Dev
2026-03-24 10:48   ` Kuldeep Singh
2026-03-23  9:17 ` [PATCH v4 06/11] arm64: dts: qcom: sc7180: " Harshal Dev
2026-03-24 10:48   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 07/11] arm64: dts: qcom: kodiak: " Harshal Dev
2026-03-24 10:37   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 08/11] arm64: dts: qcom: sm8450: " Harshal Dev
2026-03-24 10:38   ` Kuldeep Singh
2026-03-23  9:18 ` Harshal Dev [this message]
2026-03-24 10:39   ` [PATCH v4 09/11] arm64: dts: qcom: sm8550: " Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 10/11] arm64: dts: qcom: sm8650: " Harshal Dev
2026-03-24 10:39   ` Kuldeep Singh
2026-03-23  9:18 ` [PATCH v4 11/11] arm64: dts: qcom: sm8750: " Harshal Dev
2026-03-24 10:47   ` Kuldeep Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323-qcom_ice_power_and_clk_vote-v4-9-e36044bbdfe9@oss.qualcomm.com \
    --to=harshal.dev@oss.qualcomm.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=davem@davemloft.net \
    --cc=davidwronek@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=ebiggers@google.com \
    --cc=gaurav.kashyap@oss.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=neeraj.soni@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_molvera@quicinc.com \
    --cc=robh@kernel.org \
    --cc=tengfei.fan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®