* [PATCH] accel/amdxdna: fix missing newline in pr_err message
@ 2026-03-20 11:29 Haoyu Lu
2026-03-20 15:54 ` Lizhi Hou
0 siblings, 1 reply; 4+ messages in thread
From: Haoyu Lu @ 2026-03-20 11:29 UTC (permalink / raw)
To: Min Ma, Lizhi Hou, Oded Gabbay; +Cc: dri-devel, linux-kernel, haoyu.lu
From: "haoyu.lu" <hechushiguitu666@gmail.com>
Add missing newline to pr_err message in amdxdna_mailbox.c.
Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
---
drivers/accel/amdxdna/amdxdna_mailbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
index 46d844a73a94..e681a090752d 100644
--- a/drivers/accel/amdxdna/amdxdna_mailbox.c
+++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
@@ -499,7 +499,7 @@ xdna_mailbox_start_channel(struct mailbox_channel *mb_chann,
int ret;
if (!is_power_of_2(x2i->rb_size) || !is_power_of_2(i2x->rb_size)) {
- pr_err("Ring buf size must be power of 2");
+ pr_err("Ring buf size must be power of 2\n");
return -EINVAL;
}
--
2.53.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] accel/amdxdna: fix missing newline in pr_err message
2026-03-20 11:29 [PATCH] accel/amdxdna: fix missing newline in pr_err message Haoyu Lu
@ 2026-03-20 15:54 ` Lizhi Hou
2026-03-23 3:49 ` [PATCH v2] " Haoyu Lu
0 siblings, 1 reply; 4+ messages in thread
From: Lizhi Hou @ 2026-03-20 15:54 UTC (permalink / raw)
To: Haoyu Lu, Min Ma, Oded Gabbay; +Cc: dri-devel, linux-kernel
On 3/20/26 04:29, Haoyu Lu wrote:
> [You don't often get email from hechushiguitu666@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> Add missing newline to pr_err message in amdxdna_mailbox.c.
>
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
Please add 'Fixes' tag.
Lizhi
> ---
> drivers/accel/amdxdna/amdxdna_mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 46d844a73a94..e681a090752d 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -499,7 +499,7 @@ xdna_mailbox_start_channel(struct mailbox_channel *mb_chann,
> int ret;
>
> if (!is_power_of_2(x2i->rb_size) || !is_power_of_2(i2x->rb_size)) {
> - pr_err("Ring buf size must be power of 2");
> + pr_err("Ring buf size must be power of 2\n");
> return -EINVAL;
> }
>
> --
> 2.53.0.windows.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] accel/amdxdna: fix missing newline in pr_err message
2026-03-20 15:54 ` Lizhi Hou
@ 2026-03-23 3:49 ` Haoyu Lu
2026-03-23 16:40 ` Lizhi Hou
0 siblings, 1 reply; 4+ messages in thread
From: Haoyu Lu @ 2026-03-23 3:49 UTC (permalink / raw)
To: lizhi.hou; +Cc: mamin506, ogabbay, dri-devel, linux-kernel, haoyu.lu
From: "haoyu.lu" <hechushiguitu666@gmail.com>
Add missing newline to pr_err message in amdxdna_mailbox.c.
Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
---
Changes in v2:
- Added Fixes tag as requested
drivers/accel/amdxdna/amdxdna_mailbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
index 46d844a73a94..e681a090752d 100644
--- a/drivers/accel/amdxdna/amdxdna_mailbox.c
+++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
@@ -499,7 +499,7 @@ xdna_mailbox_start_channel(struct mailbox_channel *mb_chann,
int ret;
if (!is_power_of_2(x2i->rb_size) || !is_power_of_2(i2x->rb_size)) {
- pr_err("Ring buf size must be power of 2");
+ pr_err("Ring buf size must be power of 2\n");
return -EINVAL;
}
--
2.53.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] accel/amdxdna: fix missing newline in pr_err message
2026-03-23 3:49 ` [PATCH v2] " Haoyu Lu
@ 2026-03-23 16:40 ` Lizhi Hou
0 siblings, 0 replies; 4+ messages in thread
From: Lizhi Hou @ 2026-03-23 16:40 UTC (permalink / raw)
To: Haoyu Lu; +Cc: mamin506, ogabbay, dri-devel, linux-kernel
Thanks, applied to drm-misc-next.
On 3/22/26 20:49, Haoyu Lu wrote:
> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> Add missing newline to pr_err message in amdxdna_mailbox.c.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
> ---
> Changes in v2:
> - Added Fixes tag as requested
>
> drivers/accel/amdxdna/amdxdna_mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 46d844a73a94..e681a090752d 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -499,7 +499,7 @@ xdna_mailbox_start_channel(struct mailbox_channel *mb_chann,
> int ret;
>
> if (!is_power_of_2(x2i->rb_size) || !is_power_of_2(i2x->rb_size)) {
> - pr_err("Ring buf size must be power of 2");
> + pr_err("Ring buf size must be power of 2\n");
> return -EINVAL;
> }
>
> --
> 2.53.0.windows.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-23 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-20 11:29 [PATCH] accel/amdxdna: fix missing newline in pr_err message Haoyu Lu
2026-03-20 15:54 ` Lizhi Hou
2026-03-23 3:49 ` [PATCH v2] " Haoyu Lu
2026-03-23 16:40 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®