From: "Christian A. Ehrhardt" <lk@c--e.de>
To: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>
Cc: "Christian A. Ehrhardt" <lk@c--e.de>, Kees Cook <kees@kernel.org>,
Petr Mladek <pmladek@suse.com>, David Gow <davidgow@google.com>
Subject: [PATCH RESEND 3/3] lib: Fix length calculation in extract_kvec_to_sg
Date: Mon, 23 Mar 2026 22:23:50 +0100 [thread overview]
Message-ID: <20260323212350.807118-4-lk@c--e.de> (raw)
In-Reply-To: <20260323212350.807118-1-lk@c--e.de>
When extracting from a kvec to a scatterlist, do not
cross page boundaries. The required length is already
calculated but not used as intended.
The previous changes to the kunit_iov_iter.c demonstrate
that the patch is necessary.
Cc: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: stable@vger.kernel.org # v6.5+
Fixes: 018584697533 ("netfs: Add a function to extract an iterator into a scatterlist")
Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
---
lib/scatterlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index 21bc9c1f7c06..73893ee0d92d 100644
--- a/lib/scatterlist.c
+++ b/lib/scatterlist.c
@@ -1249,7 +1249,7 @@ static ssize_t extract_kvec_to_sg(struct iov_iter *iter,
else
page = virt_to_page((void *)kaddr);
- sg_set_page(sg, page, len, off);
+ sg_set_page(sg, page, seg, off);
sgtable->nents++;
sg++;
sg_max--;
--
2.43.0
next prev parent reply other threads:[~2026-03-23 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 21:23 [PATCH RESEND 0/3] Fix length calculation bug " Christian A. Ehrhardt
2026-03-23 21:23 ` [PATCH RESEND 1/3] lib: kunit_iov_iter: Improve error detection Christian A. Ehrhardt
2026-03-23 21:23 ` [PATCH RESEND 2/3] lib: kunit_iov_iter: Add tests for extract_iter_to_sg Christian A. Ehrhardt
2026-03-23 21:23 ` Christian A. Ehrhardt [this message]
2026-03-24 19:12 ` [PATCH RESEND 3/3] lib: Fix length calculation in extract_kvec_to_sg Andrew Morton
2026-03-24 19:39 ` Christian A. Ehrhardt
2026-03-24 19:15 ` Andrew Morton
2026-03-24 19:47 ` Christian A. Ehrhardt
2026-03-24 20:08 ` Andrew Morton
2026-03-24 0:03 ` [PATCH RESEND 0/3] Fix length calculation bug " Josh Law
2026-03-24 16:38 ` Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323212350.807118-4-lk@c--e.de \
--to=lk@c--e.de \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=dhowells@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®