From: Andrew Morton <akpm@linux-foundation.org>
To: "Christian A. Ehrhardt" <lk@c--e.de>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
Kees Cook <kees@kernel.org>, Petr Mladek <pmladek@suse.com>,
David Gow <davidgow@google.com>
Subject: Re: [PATCH RESEND 3/3] lib: Fix length calculation in extract_kvec_to_sg
Date: Tue, 24 Mar 2026 13:08:29 -0700 [thread overview]
Message-ID: <20260324130829.7ee9ff049d199a89ac183ce8@linux-foundation.org> (raw)
In-Reply-To: <acLqNWOLM6J7E9oP@cae.in-ulm.de>
On Tue, 24 Mar 2026 20:47:01 +0100 "Christian A. Ehrhardt" <lk@c--e.de> wrote:
>
> Hi Andrew,
>
> On Tue, Mar 24, 2026 at 12:15:52PM -0700, Andrew Morton wrote:
> > On Mon, 23 Mar 2026 22:23:50 +0100 "Christian A. Ehrhardt" <lk@c--e.de> wrote:
> >
> > > When extracting from a kvec to a scatterlist, do not
> > > cross page boundaries. The required length is already
> > > calculated but not used as intended.
> > >
> > > The previous changes to the kunit_iov_iter.c demonstrate
> > > that the patch is necessary.
> > >
> > > Cc: David Howells <dhowells@redhat.com>
> > > Cc: Andrew Morton <akpm@linux-foundation.org>
> > > Cc: stable@vger.kernel.org # v6.5+
> >
> > But 018584697533 was first released in 6.10?
>
> No, it was first in 6.3:
> | $ git log v6.3 | grep -A3 "commit 018584697533"
> | commit 0185846975339a5c348373aa450a977f5242366b
> | Author: David Howells <dhowells@redhat.com>
> | Date: Thu Oct 27 16:19:44 2022 +0100
hp2:/usr/src/mm> git show --pretty=fuller 018584697533 | head -n10
commit 0185846975339a5c348373aa450a977f5242366b
Author: David Howells <dhowells@redhat.com>
AuthorDate: Thu Oct 27 16:19:44 2022 +0100
Commit: Steve French <stfrench@microsoft.com>
CommitDate: Mon Feb 20 17:25:43 2023 -0600
It obviously got stalled somewhere for a while.
>
> > I'll remove the " v6.5+" - it isn't needed when we have the Fixes: hash.
>
> Please don't. The patch will only apply without modification
> for v6.5+ because the function was moved to a different file.
> As the only stable kernels in that range are 6.1 and 6.6 the
> v6.5+ should be sufficient?
hp2:/usr/src/mm> git tag --contains 018584697533 | grep "^v[0-9]*" | head
v6.10
v6.10-rc1
v6.10-rc2
v6.10-rc3
v6.10-rc4
v6.10-rc5
v6.10-rc6
v6.10-rc7
v6.11
> > But please do check that 018584697533 was the correct target.
>
> It is, see above.
>
> I have an updated verion of the series almost ready that addresses
> some of the AI review comments. Should I send an updated version or
> incremental patches?
A new series will work, thanks.
next prev parent reply other threads:[~2026-03-24 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 21:23 [PATCH RESEND 0/3] Fix length calculation bug " Christian A. Ehrhardt
2026-03-23 21:23 ` [PATCH RESEND 1/3] lib: kunit_iov_iter: Improve error detection Christian A. Ehrhardt
2026-03-23 21:23 ` [PATCH RESEND 2/3] lib: kunit_iov_iter: Add tests for extract_iter_to_sg Christian A. Ehrhardt
2026-03-23 21:23 ` [PATCH RESEND 3/3] lib: Fix length calculation in extract_kvec_to_sg Christian A. Ehrhardt
2026-03-24 19:12 ` Andrew Morton
2026-03-24 19:39 ` Christian A. Ehrhardt
2026-03-24 19:15 ` Andrew Morton
2026-03-24 19:47 ` Christian A. Ehrhardt
2026-03-24 20:08 ` Andrew Morton [this message]
2026-03-24 0:03 ` [PATCH RESEND 0/3] Fix length calculation bug " Josh Law
2026-03-24 16:38 ` Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324130829.7ee9ff049d199a89ac183ce8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=dhowells@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lk@c--e.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®