From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Kiryl Shutsemau <kas@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
kvm@vger.kernel.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH 0/2] x86/tdx: Fix memory hotplug in TDX guests
Date: Tue, 24 Mar 2026 19:21:46 +0400 [thread overview]
Message-ID: <20260324-tdx-hotplug-fixes-v1-0-8f29f2c17278@redhat.com> (raw)
In TDX guests, hotplugged memory (e.g., via virtio-mem) must be accepted
via TDG.MEM.PAGE.ACCEPT before use. The first access to an unaccepted
page triggers a fatal "SEPT entry in PENDING state" EPT violation and
KVM terminates the guest.
This was discovered while testing virtio-mem resize with TDX guests.
The associated QEMU virtio-mem + TDX patch series is under review at:
https://patchew.org/QEMU/20260226140001.3622334-1-marcandre.lureau@redhat.com/
The fix has two parts:
1. Handle TDG.MEM.PAGE.ACCEPT "success-with-warning" returns for pages
that are already in MAPPED state (e.g., after offline/re-online
cycles), instead of treating them as fatal errors.
2. Register a MEM_GOING_ONLINE memory hotplug notifier that calls
tdx_accept_memory() before pages are freed to the buddy allocator.
The TDCALL transparently triggers KVM-side page augmentation (AUG)
followed by acceptance, avoiding the fatal EPT violation path.
The solution was suggested by Claude Code (Anthropic) and has been
tested with virtio-mem hot-add on a TDX guest. I did my best to review
the produced code and comments. Apologies if the agent did hallucinate.
Let me know if I need to check or correct something.
Thanks,
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
Marc-André Lureau (2):
x86/tdx: Handle TDG.MEM.PAGE.ACCEPT success-with-warning returns
x86/tdx: Accept hotplugged memory before online
arch/x86/coco/tdx/tdx-shared.c | 2 +-
arch/x86/coco/tdx/tdx.c | 38 ++++++++++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+), 1 deletion(-)
---
base-commit: c369299895a591d96745d6492d4888259b004a9e
change-id: 20260324-tdx-hotplug-fixes-644d009dad63
Best regards,
--
Marc-André Lureau <marcandre.lureau@redhat.com>
next reply other threads:[~2026-03-24 15:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 15:21 Marc-André Lureau [this message]
2026-03-24 15:21 ` [PATCH 1/2] x86/tdx: Handle TDG.MEM.PAGE.ACCEPT success-with-warning returns Marc-André Lureau
2026-03-24 22:02 ` Edgecombe, Rick P
2026-03-24 15:21 ` [PATCH 2/2] x86/tdx: Accept hotplugged memory before online Marc-André Lureau
2026-03-24 22:03 ` Edgecombe, Rick P
2026-03-25 10:29 ` Marc-André Lureau
2026-03-25 17:21 ` Edgecombe, Rick P
2026-03-26 18:25 ` Paolo Bonzini
2026-03-26 20:40 ` Edgecombe, Rick P
2026-03-30 12:29 ` Kiryl Shutsemau
2026-03-30 15:10 ` Pratik R. Sampat
2026-04-01 15:37 ` Edgecombe, Rick P
2026-04-01 15:49 ` Edgecombe, Rick P
2026-04-02 8:18 ` Reshetova, Elena
2026-04-02 17:06 ` Edgecombe, Rick P
2026-04-03 10:37 ` Reshetova, Elena
2026-04-03 19:41 ` Edgecombe, Rick P
2026-04-08 8:22 ` Reshetova, Elena
2026-04-08 19:55 ` Pratik R. Sampat
2026-04-09 1:35 ` Duan, Zhenzhong
2026-04-09 15:19 ` Marc-André Lureau
2026-04-10 1:05 ` Duan, Zhenzhong
2026-04-10 7:49 ` David Hildenbrand (Arm)
2026-03-27 3:05 ` Chenyi Qiang
2026-03-27 8:49 ` David Hildenbrand (Arm)
2026-03-27 8:28 ` Yan Zhao
2026-03-30 12:17 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324-tdx-hotplug-fixes-v1-0-8f29f2c17278@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=bp@alien8.de \
--cc=chenyi.qiang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®