From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Kiryl Shutsemau <kas@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
kvm@vger.kernel.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH 1/2] x86/tdx: Handle TDG.MEM.PAGE.ACCEPT success-with-warning returns
Date: Tue, 24 Mar 2026 19:21:47 +0400 [thread overview]
Message-ID: <20260324-tdx-hotplug-fixes-v1-1-8f29f2c17278@redhat.com> (raw)
In-Reply-To: <20260324-tdx-hotplug-fixes-v1-0-8f29f2c17278@redhat.com>
try_accept_one() treats any non-zero return from __tdcall() as a
failure. However, per the TDX Module Base Spec (Table SEPT Walk Cases),
TDG.MEM.PAGE.ACCEPT returns a non-zero status code with bit 63 clear
when the target page is already in MAPPED state (i.e., already
accepted). This is a "success-with-warning" -- the page is usable and no
action is needed.
Check only bit 63 (TDX_ERROR) to distinguish real errors from
success-with-warning returns, rather than treating all non-zero values
as failures.
Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
arch/x86/coco/tdx/tdx-shared.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/coco/tdx/tdx-shared.c b/arch/x86/coco/tdx/tdx-shared.c
index 1655aa56a0a51..24983601a2ded 100644
--- a/arch/x86/coco/tdx/tdx-shared.c
+++ b/arch/x86/coco/tdx/tdx-shared.c
@@ -35,7 +35,7 @@ static unsigned long try_accept_one(phys_addr_t start, unsigned long len,
}
args.rcx = start | page_size;
- if (__tdcall(TDG_MEM_PAGE_ACCEPT, &args))
+ if (__tdcall(TDG_MEM_PAGE_ACCEPT, &args) & TDX_ERROR)
return 0;
return accept_size;
--
2.53.0
next prev parent reply other threads:[~2026-03-24 15:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 15:21 [PATCH 0/2] x86/tdx: Fix memory hotplug in TDX guests Marc-André Lureau
2026-03-24 15:21 ` Marc-André Lureau [this message]
2026-03-24 22:02 ` [PATCH 1/2] x86/tdx: Handle TDG.MEM.PAGE.ACCEPT success-with-warning returns Edgecombe, Rick P
2026-03-24 15:21 ` [PATCH 2/2] x86/tdx: Accept hotplugged memory before online Marc-André Lureau
2026-03-24 22:03 ` Edgecombe, Rick P
2026-03-25 10:29 ` Marc-André Lureau
2026-03-25 17:21 ` Edgecombe, Rick P
2026-03-26 18:25 ` Paolo Bonzini
2026-03-26 20:40 ` Edgecombe, Rick P
2026-03-30 12:29 ` Kiryl Shutsemau
2026-03-30 15:10 ` Pratik R. Sampat
2026-04-01 15:37 ` Edgecombe, Rick P
2026-04-01 15:49 ` Edgecombe, Rick P
2026-04-02 8:18 ` Reshetova, Elena
2026-04-02 17:06 ` Edgecombe, Rick P
2026-04-03 10:37 ` Reshetova, Elena
2026-04-03 19:41 ` Edgecombe, Rick P
2026-04-08 8:22 ` Reshetova, Elena
2026-04-08 19:55 ` Pratik R. Sampat
2026-04-09 1:35 ` Duan, Zhenzhong
2026-04-09 15:19 ` Marc-André Lureau
2026-04-10 1:05 ` Duan, Zhenzhong
2026-04-10 7:49 ` David Hildenbrand (Arm)
2026-03-27 3:05 ` Chenyi Qiang
2026-03-27 8:49 ` David Hildenbrand (Arm)
2026-03-27 8:28 ` Yan Zhao
2026-03-30 12:17 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324-tdx-hotplug-fixes-v1-1-8f29f2c17278@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=bp@alien8.de \
--cc=chenyi.qiang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®