From: Andrew Morton <akpm@linux-foundation.org>
To: Leo Timmins <leotimmins1974@gmail.com>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
Mike Rapoport <rppt@kernel.org>,
Pratyush Yadav <pratyush@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] liveupdate: propagate file deserialization failures
Date: Wed, 25 Mar 2026 20:50:59 -0700 [thread overview]
Message-ID: <20260325205059.62072d848043542f922aa564@linux-foundation.org> (raw)
In-Reply-To: <20260325044608.8407-2-leotimmins1974@gmail.com>
On Wed, 25 Mar 2026 12:46:07 +0800 Leo Timmins <leotimmins1974@gmail.com> wrote:
> luo_session_deserialize() ignored the return value from
> luo_file_deserialize(). As a result, a session could be left partially
> restored even though the /dev/liveupdate open path treats deserialization
> failures as fatal.
>
> Propagate the error so a failed file deserialization aborts session
> deserialization instead of silently continuing.
>
> Fixes: 16cec0d26521 ("liveupdate: luo_session: add ioctls for file preservation")
Present in 6.19. Is this serious enough for a -stable backport?
Leo, I'll add this to mm.git's mm-hotfixes branch because "fix".
Please do send along a v2 which addresses Pasha's comments.
next prev parent reply other threads:[~2026-03-26 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 4:46 [PATCH v2 0/2] liveupdate: fix incoming error handling and teardown paths Leo Timmins
2026-03-25 4:46 ` [PATCH v2 1/2] liveupdate: propagate file deserialization failures Leo Timmins
2026-03-25 13:05 ` Pasha Tatashin
2026-03-26 3:50 ` Andrew Morton [this message]
2026-03-25 4:46 ` [PATCH v2 2/2] liveupdate: initialize incoming FLB state before finish Leo Timmins
2026-03-25 13:08 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325205059.62072d848043542f922aa564@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=leotimmins1974@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®