[PATCH] ARM: dts: am335x-sl50: Fix audio bitclock and frame master endpoint

[PATCH] ARM: dts: am335x-sl50: Fix audio bitclock and frame master endpoint

[Jihed Chaibi]

The cpu_endpoint in mcasp0 specifies the TLV320AIC3106 codec as the
bitclock and frame master, but the phandles point to the codec's port
node (codec_port) rather than its endpoint node (codec_endpoint).

audio-graph-card calls simple_util_parse_daifmt() with ep_codec set to
the endpoint node (codec_endpoint). The function resolves the
bitclock-master phandle and checks whether it equals ep_codec. Since
codec_port is the parent of codec_endpoint, not the endpoint itself, the
comparison always evaluates to false. This causes the mcasp0 CPU side to
be silently configured as bitclock and frame master instead of the codec,
which is the opposite of the intended configuration.

Fix by pointing bitclock-master and frame-master to codec_endpoint.

Fixes: e5f89dbdebc5 ("ARM: dts: am335x-sl50: use audio-graph-card for sound")
Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
 arch/arm/boot/dts/ti/omap/am335x-sl50.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-sl50.dts b/arch/arm/boot/dts/ti/omap/am335x-sl50.dts
index 1dc4e344efd6..b3a7f2c91d4e 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sl50.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sl50.dts
@@ -558,8 +558,8 @@ cpu_endpoint: endpoint {
 			remote-endpoint = <&codec_endpoint>;

 			dai-format = "dsp_b";
-			bitclock-master = <&codec_port>;
-			frame-master = <&codec_port>;
+			bitclock-master = <&codec_endpoint>;
+			frame-master = <&codec_endpoint>;
 			bitclock-inversion;
 			clocks = <&audio_mclk>;
 		};
--
2.47.3

Re: [PATCH] ARM: dts: am335x-sl50: Fix audio bitclock and frame master endpoint

[Kevin Hilman]

On Wed, 25 Mar 2026 23:34:11 +0100, Jihed Chaibi wrote:
> The cpu_endpoint in mcasp0 specifies the TLV320AIC3106 codec as the
> bitclock and frame master, but the phandles point to the codec's port
> node (codec_port) rather than its endpoint node (codec_endpoint).
> 
> audio-graph-card calls simple_util_parse_daifmt() with ep_codec set to
> the endpoint node (codec_endpoint). The function resolves the
> bitclock-master phandle and checks whether it equals ep_codec. Since
> codec_port is the parent of codec_endpoint, not the endpoint itself, the
> comparison always evaluates to false. This causes the mcasp0 CPU side to
> be silently configured as bitclock and frame master instead of the codec,
> which is the opposite of the intended configuration.
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: am335x-sl50: Fix audio bitclock and frame master endpoint
      commit: 2bc564f46b00dc4f4331fc337277ff3f5fac8a4e

Best regards,
-- 
Kevin Hilman (TI) <khilman@baylibre.com>