mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Haoyu Lu <hechushiguitu666@gmail.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: ad525x_dpot: fix macro parentheses and permissions
Date: Thu, 26 Mar 2026 10:04:55 +0100	[thread overview]
Message-ID: <2026032613-chlorine-pauper-4759@gregkh> (raw)
In-Reply-To: <20260326085514.14505-1-hechushiguitu666@gmail.com>

On Thu, Mar 26, 2026 at 04:55:10PM +0800, Haoyu Lu wrote:
> From: "haoyu.lu" <hechushiguitu666@gmail.com>
> 
> Fix checkpatch.pl warnings:
> - Macros with complex values should be enclosed in parentheses
> - Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred
> 
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>

Please do not do checkpatch cleanups in other areas of the kernel when
you do not have the experience of doing them first in drivers/staging/
as due to a number of problems in this patch, it obviously can not be
applied :(

thanks,

greg k-h

      reply	other threads:[~2026-03-26  9:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  8:55 Haoyu Lu
2026-03-26  9:04 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026032613-chlorine-pauper-4759@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=hechushiguitu666@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®