mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
	"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH] hwmon: (ina2xx) drop unused platform data
Date: Thu, 26 Mar 2026 20:22:02 +0000	[thread overview]
Message-ID: <20260326202202.69510f44@jic23-huawei> (raw)
In-Reply-To: <CAMRc=MfYixLYcYz20dv9Afek77b3cqQh7nne93WLOusHnyJKMA@mail.gmail.com>

On Thu, 26 Mar 2026 14:24:20 +0100
Bartosz Golaszewski <brgl@kernel.org> wrote:

> On Thu, Mar 26, 2026 at 12:33 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On Thu, Mar 26, 2026 at 04:28:16AM -0700, Guenter Roeck wrote:  
> > > Hi,
> > >
> > > On Thu, Mar 26, 2026 at 10:30:00AM +0100, Bartosz Golaszewski wrote:  
> > > > Nobody defines struct ina2xx_platform_data. Remove platform data support
> > > > from the drivers which still have it (it's effectively dead code) and
> > > > remove the header.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>  
> > >
> > > Thanks a lot for your patch. Checkpatch complains:
> > >
> > > CHECK: Alignment should match open parenthesis
> > >
> > > No need to resend, I'll fix that up.
> > >
> > > Applied.
> > >  
> >
> > Ah, no, I can not do that. You also touched drivers/iio/adc/ina2xx-adc.c,
> > meaning I'll either need an Ack from Jonathan or the patch will need to be
> > split.
> >
> > Guenter  
> 
> Yes, sorry I should have mentioned it. This should go through the
> hwmon tree with an Ack from iio maintainers.
Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com>

I have one patch on this driver queued on this driver, but the patch seems
to apply just fine on top of that so hopefully the merge will be automatic
/ trivial.
https://lore.kernel.org/all/20260315182304.613783-1-git@chuang.cz/


> 
> Bart


  reply	other threads:[~2026-03-26 20:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  9:30 Bartosz Golaszewski
2026-03-26 10:23 ` Andy Shevchenko
2026-03-26 14:12   ` Guenter Roeck
2026-03-26 18:25     ` Andy Shevchenko
2026-03-26 11:28 ` Guenter Roeck
2026-03-26 11:33   ` Guenter Roeck
2026-03-26 13:24     ` Bartosz Golaszewski
2026-03-26 20:22       ` Jonathan Cameron [this message]
2026-03-26 23:43 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326202202.69510f44@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®