From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
brgl@kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] hwmon: (ina2xx) drop unused platform data
Date: Thu, 26 Mar 2026 20:25:01 +0200 [thread overview]
Message-ID: <acV5_YSGKtlTa4hP@ashevche-desk.local> (raw)
In-Reply-To: <b692b3db-75f2-43d0-8b2e-c5a89b8ff5ca@roeck-us.net>
On Thu, Mar 26, 2026 at 07:12:16AM -0700, Guenter Roeck wrote:
> On Thu, Mar 26, 2026 at 12:23:20PM +0200, Andy Shevchenko wrote:
> > On Thu, Mar 26, 2026 at 10:30:00AM +0100, Bartosz Golaszewski wrote:
> > > Nobody defines struct ina2xx_platform_data. Remove platform data support
> > > from the drivers which still have it (it's effectively dead code) and
> > > remove the header.
> >
> > Would be nice to see a follow up to convert to use device properties.
> > But again, I already asked this Q: why do we have two drivers for the
> > same part? (Probably not to you, Bart)
>
> Because the person introducing the iio driver claimed that they needed
> the iio ABI and were unwilling to create a generic hwmon->iio bridge.
Okay, but why did we allow that? I fell uncomfortable to bear two drivers
of the same when the whole idea of the kernel is reduce duplication. Yes,
I know that there are more cross-subsystem examples that we have IIO vs.
other subsystem cases (usually in drivers/input), but I believe it was
historical and for new devices I would like to have a stricter rules. IIO
hwmon bridge is exactly for that and if it lacks something we rather should
discuss improving that instead of duplications.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-26 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 9:30 Bartosz Golaszewski
2026-03-26 10:23 ` Andy Shevchenko
2026-03-26 14:12 ` Guenter Roeck
2026-03-26 18:25 ` Andy Shevchenko [this message]
2026-03-26 11:28 ` Guenter Roeck
2026-03-26 11:33 ` Guenter Roeck
2026-03-26 13:24 ` Bartosz Golaszewski
2026-03-26 20:22 ` Jonathan Cameron
2026-03-26 23:43 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acV5_YSGKtlTa4hP@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®