[PATCH] fs: write a better comment in step_into() concerning .mnt assignment

[PATCH] fs: write a better comment in step_into() concerning .mnt assignment

[Mateusz Guzik]

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
 fs/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namei.c b/fs/namei.c
index 2113958c3b7a..c7fac83c9a85 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2140,7 +2140,7 @@ static __always_inline const char *step_into(struct nameidata *nd, int flags,
 		if (unlikely(!inode))
 			return ERR_PTR(-ENOENT);
 		nd->path.dentry = dentry;
-		/* nd->path.mnt is retained on purpose */
+		/* nd->path.mnt remains unchanged as no mount point was crossed */
 		nd->inode = inode;
 		nd->seq = nd->next_seq;
 		return NULL;
-- 
2.48.1

Re: [PATCH] fs: write a better comment in step_into() concerning .mnt assignment

[Jan Kara]

On Sat 28-03-26 18:58:40, Mateusz Guzik wrote:
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 2113958c3b7a..c7fac83c9a85 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2140,7 +2140,7 @@ static __always_inline const char *step_into(struct nameidata *nd, int flags,
>  		if (unlikely(!inode))
>  			return ERR_PTR(-ENOENT);
>  		nd->path.dentry = dentry;
> -		/* nd->path.mnt is retained on purpose */
> +		/* nd->path.mnt remains unchanged as no mount point was crossed */
>  		nd->inode = inode;
>  		nd->seq = nd->next_seq;
>  		return NULL;
> -- 
> 2.48.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] fs: write a better comment in step_into() concerning .mnt assignment

[Christian Brauner]

On Sat, 28 Mar 2026 18:58:40 +0100, Mateusz Guzik wrote:
> 


Applied to the vfs-7.1.misc branch of the vfs/vfs.git tree.
Patches in the vfs-7.1.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.1.misc

[1/1] fs: write a better comment in step_into() concerning .mnt assignment
      https://git.kernel.org/vfs/vfs/c/18f2e0ea200c