* [PATCH] dt-bindings: rtc: moxa,moxart-rtc: convert to json-schema
@ 2026-03-29 18:46 Serban-Pascu Robert
2026-03-30 7:34 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Serban-Pascu Robert @ 2026-03-29 18:46 UTC (permalink / raw)
To: alexandre.belloni
Cc: robh, krzk+dt, conor+dt, devicetree, linux-rtc, linux-kernel,
daniel.baluta, Serban-Pascu Robert
Convert the MOXA ART real-time clock text binding to DT schema.
Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
---
.../bindings/rtc/moxa,moxart-rtc.txt | 17 --------
.../bindings/rtc/moxa,moxart-rtc.yaml | 43 +++++++++++++++++++
2 files changed, 43 insertions(+), 17 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt
create mode 100644 Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.yaml
diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt
deleted file mode 100644
index 1374df7bf9d6..000000000000
--- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-MOXA ART real-time clock
-
-Required properties:
-
-- compatible : Should be "moxa,moxart-rtc"
-- rtc-sclk-gpios : RTC sclk gpio, with zero flags
-- rtc-data-gpios : RTC data gpio, with zero flags
-- rtc-reset-gpios : RTC reset gpio, with zero flags
-
-Example:
-
- rtc: rtc {
- compatible = "moxa,moxart-rtc";
- rtc-sclk-gpios = <&gpio 5 0>;
- rtc-data-gpios = <&gpio 6 0>;
- rtc-reset-gpios = <&gpio 7 0>;
- };
diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.yaml b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.yaml
new file mode 100644
index 000000000000..6b8f6e5f99e9
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/moxa,moxart-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MOXA ART Real-time Clock
+
+maintainers:
+ - Serban-Pascu Robert <robyserbanpascu06@gmail.com>
+
+properties:
+ compatible:
+ const: moxa,moxart-rtc
+
+ rtc-sclk-gpios:
+ maxItems: 1
+ description: GPIO line for the RTC clock signal.
+
+ rtc-data-gpios:
+ maxItems: 1
+ description: GPIO line for the RTC data signal.
+
+ rtc-reset-gpios:
+ maxItems: 1
+ description: GPIO line for the RTC reset signal.
+
+required:
+ - compatible
+ - rtc-sclk-gpios
+ - rtc-data-gpios
+ - rtc-reset-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ rtc {
+ compatible = "moxa,moxart-rtc";
+ rtc-sclk-gpios = <&gpio 5 0>;
+ rtc-data-gpios = <&gpio 6 0>;
+ rtc-reset-gpios = <&gpio 7 0>;
+ };
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: rtc: moxa,moxart-rtc: convert to json-schema
2026-03-29 18:46 [PATCH] dt-bindings: rtc: moxa,moxart-rtc: convert to json-schema Serban-Pascu Robert
@ 2026-03-30 7:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-30 7:34 UTC (permalink / raw)
To: Serban-Pascu Robert
Cc: alexandre.belloni, robh, krzk+dt, conor+dt, devicetree,
linux-rtc, linux-kernel, daniel.baluta
On Sun, Mar 29, 2026 at 09:46:15PM +0300, Serban-Pascu Robert wrote:
> Convert the MOXA ART real-time clock text binding to DT schema.
>
> Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
> ---
> .../bindings/rtc/moxa,moxart-rtc.txt | 17 --------
> .../bindings/rtc/moxa,moxart-rtc.yaml | 43 +++++++++++++++++++
Is this another part of GSoC or independent try to hop-on the same bus?
I am asking because in both cases I expect you to follow GSoC
guidelines.
And this was not tested - you have clear warnings in dtbs for deprecated
properties.
This is not a trivial binding and you were supposed to do a detailed
check in git history and in all existing sources.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-30 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-29 18:46 [PATCH] dt-bindings: rtc: moxa,moxart-rtc: convert to json-schema Serban-Pascu Robert
2026-03-30 7:34 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®