mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] nvmem: cleanup dead code in Kconfig
@ 2026-03-31 12:04 Julian Braha
  2026-05-19 15:57 ` Srinivas Kandagatla
  0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2026-03-31 12:04 UTC (permalink / raw)
  To: srini; +Cc: rafal, sboyd, linux-kernel, Julian Braha

There is already an 'if NVMEM' condition wrapping NVMEM_RCAR_EFUSE,
making the 'depends on' statement a duplicate dependency (dead code).

I propose leaving the outer 'if NVMEM...endif' and removing the
individual 'depends on' statement.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/nvmem/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 74ddbd0f79b0..a6f422a5a9a5 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -303,7 +303,6 @@ config NVMEM_RAVE_SP_EEPROM
 config NVMEM_RCAR_EFUSE
 	tristate "Renesas R-Car Gen4 E-FUSE support"
 	depends on (ARCH_RENESAS && ARM64) || COMPILE_TEST
-	depends on NVMEM
 	help
 	  Enable support for reading the fuses in the E-FUSE or OTP
 	  non-volatile memory block on Renesas R-Car Gen4 SoCs.
@@ -483,4 +482,4 @@ config NVMEM_QORIQ_EFUSE
 	  This driver can also be built as a module. If so, the module
 	  will be called nvmem_qoriq_efuse.
 
-endif
+endif # NVMEM
-- 
2.51.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nvmem: cleanup dead code in Kconfig
  2026-03-31 12:04 [PATCH] nvmem: cleanup dead code in Kconfig Julian Braha
@ 2026-05-19 15:57 ` Srinivas Kandagatla
  0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2026-05-19 15:57 UTC (permalink / raw)
  To: Julian Braha; +Cc: rafal, sboyd, linux-kernel


On Tue, 31 Mar 2026 13:04:59 +0100, Julian Braha wrote:
> There is already an 'if NVMEM' condition wrapping NVMEM_RCAR_EFUSE,
> making the 'depends on' statement a duplicate dependency (dead code).
> 
> I propose leaving the outer 'if NVMEM...endif' and removing the
> individual 'depends on' statement.
> 
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
> 
> [...]

Applied, thanks!

[1/1] nvmem: cleanup dead code in Kconfig
      commit: 3a99fdfe8380f5d7c5f9e652187681c471fa4a27

Best regards,
-- 
Srinivas Kandagatla <srini@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-19 15:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-31 12:04 [PATCH] nvmem: cleanup dead code in Kconfig Julian Braha
2026-05-19 15:57 ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®