mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marco Nenciarini <mnencia@kcore.it>
To: "Daniel Scally" <djrscally@gmail.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Hans de Goede <johannes.goede@oss.qualcomm.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, Marco Nenciarini <mnencia@kcore.it>
Subject: [PATCH v7 0/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)
Date: Tue, 31 Mar 2026 15:44:39 +0200	[thread overview]
Message-ID: <20260331134443.1573053-1-mnencia@kcore.it> (raw)

Add support for INT3472 GPIO type 0x02 which controls an IR flood LED
used for face authentication on some laptops (e.g. Dell Pro Max 16
Premium). Without this, the kernel logs "GPIO type 0x02 unknown; the
sensor may not work" and IR sensors paired with a flood LED cannot
function.

The series first refactors the existing LED code (patches 1-3), then
adds the new IR flood LED type with multi-LED support (patch 4).

Changes in v7:
- Combined function parameters onto a single line in the brightness
  callback to avoid alignment churn across patches (patch 1)
- Fixed indentation after pled_set to led_set rename (patch 2)
- Renamed GPIO con_id from "privacy-led" to "privacy" and passed it
  from the caller to reduce churn (patch 3)
- Avoided unnecessary line wrap in function declaration (patch 3)
- Replaced bool add_lookup parameter with u8 type and switch-case
  for lookup logic in the callee (patch 4)
- Simplified caller to use fallthrough for PRIVACY_LED/STROBE (patch 4)

Marco Nenciarini (4):
  platform/x86: int3472: Use local variable for LED struct access
  platform/x86: int3472: Rename pled to led in LED registration code
  platform/x86: int3472: Parameterize LED con_id in registration
  platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)

 drivers/platform/x86/intel/int3472/discrete.c | 13 +++-
 drivers/platform/x86/intel/int3472/led.c      | 66 +++++++++++--------
 include/linux/platform_data/x86/int3472.h     | 12 ++--
 3 files changed, 58 insertions(+), 33 deletions(-)

-- 
2.47.3


             reply	other threads:[~2026-03-31 13:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 13:44 Marco Nenciarini [this message]
2026-03-31 13:44 ` [PATCH v7 1/4] platform/x86: int3472: Use local variable for LED struct access Marco Nenciarini
2026-04-01 13:40   ` Hans de Goede
2026-03-31 13:44 ` [PATCH v7 2/4] platform/x86: int3472: Rename pled to led in LED registration code Marco Nenciarini
2026-04-01 13:42   ` Hans de Goede
2026-03-31 13:44 ` [PATCH v7 3/4] platform/x86: int3472: Parameterize LED con_id in registration Marco Nenciarini
2026-03-31 18:50   ` Andy Shevchenko
2026-04-01 13:43   ` Hans de Goede
2026-03-31 13:44 ` [PATCH v7 4/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED) Marco Nenciarini
2026-03-31 18:54   ` Andy Shevchenko
2026-04-01 13:45   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331134443.1573053-1-mnencia@kcore.it \
    --to=mnencia@kcore.it \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®