From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it
Date: Tue, 31 Mar 2026 17:07:01 +0200 [thread overview]
Message-ID: <20260331150701.3844815-1-mjguzik@gmail.com> (raw)
I failed to notice the change which added get_kernel_nofault() usage
removed it. It very much is still applicable.
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
fs/inode.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index 5e5cddd76a9d..912831645f38 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -3100,6 +3100,12 @@ EXPORT_SYMBOL(mode_strip_sgid);
*
* If inode is an invalid pointer, we don't want to crash accessing it,
* so probe everything depending on it carefully with get_kernel_nofault().
+ *
+ * TODO:
+ * - add more fields
+ * - pretty print flags instead of merely showing numerical values
+ * - consider extending inode ops with a ->dump_inode func so that filesystems
+ * can print additional information
*/
void dump_inode(struct inode *inode, const char *reason)
{
--
2.48.1
next reply other threads:[~2026-03-31 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 15:07 Mateusz Guzik [this message]
2026-04-01 9:27 ` Jan Kara
2026-04-01 20:18 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331150701.3844815-1-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®