[PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it

[PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it

[Mateusz Guzik]

I failed to notice the change which added get_kernel_nofault() usage
removed it. It very much is still applicable.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
 fs/inode.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/inode.c b/fs/inode.c
index 5e5cddd76a9d..912831645f38 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -3100,6 +3100,12 @@ EXPORT_SYMBOL(mode_strip_sgid);
  *
  * If inode is an invalid pointer, we don't want to crash accessing it,
  * so probe everything depending on it carefully with get_kernel_nofault().
+ *
+ * TODO:
+ * - add more fields
+ * - pretty print flags instead of merely showing numerical values
+ * - consider extending inode ops with a ->dump_inode func so that filesystems
+ *   can print additional information
  */
 void dump_inode(struct inode *inode, const char *reason)
 {
-- 
2.48.1

Re: [PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it

[Jan Kara]

On Tue 31-03-26 17:07:01, Mateusz Guzik wrote:
> I failed to notice the change which added get_kernel_nofault() usage
> removed it. It very much is still applicable.
> 
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>

I'm not strictly opposed but at the same time I'm not sure about the value
of such TODO comments. Maybe better track it in some kernel-newbies project
or something like that? I know there are lists of beginner's kernel tasks
out there.

								Honza

> ---
>  fs/inode.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index 5e5cddd76a9d..912831645f38 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -3100,6 +3100,12 @@ EXPORT_SYMBOL(mode_strip_sgid);
>   *
>   * If inode is an invalid pointer, we don't want to crash accessing it,
>   * so probe everything depending on it carefully with get_kernel_nofault().
> + *
> + * TODO:
> + * - add more fields
> + * - pretty print flags instead of merely showing numerical values
> + * - consider extending inode ops with a ->dump_inode func so that filesystems
> + *   can print additional information
>   */
>  void dump_inode(struct inode *inode, const char *reason)
>  {
> -- 
> 2.48.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it

[Mateusz Guzik]

On Wed, Apr 1, 2026 at 11:27 AM Jan Kara <jack@suse.cz> wrote:
>
> On Tue 31-03-26 17:07:01, Mateusz Guzik wrote:
> > I failed to notice the change which added get_kernel_nofault() usage
> > removed it. It very much is still applicable.
> >
> > Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
>
> I'm not strictly opposed but at the same time I'm not sure about the value
> of such TODO comments. Maybe better track it in some kernel-newbies project
> or something like that? I know there are lists of beginner's kernel tasks
> out there.
>

This is just few lines towards the end of the file, I don't think it
should bother anyone.

I can't be bothered to add this elsewhere and I'm not going to argue
one way or the other. if this patch gets dropped, so be it.