* net/core/dev.c:4776:21: warning: 'ether_addr_equal_64bits' reading 8 bytes from a region of size 6
@ 2026-04-07 3:56 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-04-07 3:56 UTC (permalink / raw)
To: Martin Willi; +Cc: oe-kbuild-all, linux-kernel, Daniel Borkmann
Hi Martin,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3aae9383f42f687221c011d7ee87529398e826b3
commit: 22b6034323fd736f260e00b9ea85c634abeb3446 net, xdp: Update pkt_type if generic XDP changes unicast MAC
date: 4 years, 11 months ago
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20260405/202604050634.aMvcQA8p-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260405/202604050634.aMvcQA8p-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 22b6034323fd ("net, xdp: Update pkt_type if generic XDP changes unicast MAC")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604050634.aMvcQA8p-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/core/dev.c: In function 'netif_receive_generic_xdp':
>> net/core/dev.c:4776:21: warning: 'ether_addr_equal_64bits' reading 8 bytes from a region of size 6 [-Wstringop-overread]
4776 | orig_host = ether_addr_equal_64bits(eth->h_dest, skb->dev->dev_addr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:4776:21: note: referencing argument 1 of type 'const u8[8]' {aka 'const unsigned char[8]'}
net/core/dev.c:4776:21: note: referencing argument 2 of type 'const u8[8]' {aka 'const unsigned char[8]'}
In file included from net/core/dev.c:91:
include/linux/etherdevice.h:355:20: note: in a call to function 'ether_addr_equal_64bits'
355 | static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
| ^~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:4777:22: warning: 'is_multicast_ether_addr_64bits' reading 8 bytes from a region of size 6 [-Wstringop-overread]
4777 | orig_bcast = is_multicast_ether_addr_64bits(eth->h_dest);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:4777:22: note: referencing argument 1 of type 'const u8[8]' {aka 'const unsigned char[8]'}
include/linux/etherdevice.h:130:20: note: in a call to function 'is_multicast_ether_addr_64bits'
130 | static inline bool is_multicast_ether_addr_64bits(const u8 addr[6+2])
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:4804:27: warning: 'ether_addr_equal_64bits' reading 8 bytes from a region of size 6 [-Wstringop-overread]
4804 | (orig_host != ether_addr_equal_64bits(eth->h_dest,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4805 | skb->dev->dev_addr)) ||
| ~~~~~~~~~~~~~~~~~~~
net/core/dev.c:4804:27: note: referencing argument 1 of type 'const u8[8]' {aka 'const unsigned char[8]'}
net/core/dev.c:4804:27: note: referencing argument 2 of type 'const u8[8]' {aka 'const unsigned char[8]'}
include/linux/etherdevice.h:355:20: note: in a call to function 'ether_addr_equal_64bits'
355 | static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
| ^~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:4806:28: warning: 'is_multicast_ether_addr_64bits' reading 8 bytes from a region of size 6 [-Wstringop-overread]
4806 | (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:4806:28: note: referencing argument 1 of type 'const u8[8]' {aka 'const unsigned char[8]'}
include/linux/etherdevice.h:130:20: note: in a call to function 'is_multicast_ether_addr_64bits'
130 | static inline bool is_multicast_ether_addr_64bits(const u8 addr[6+2])
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/ether_addr_equal_64bits +4776 net/core/dev.c
4718
4719 static u32 netif_receive_generic_xdp(struct sk_buff *skb,
4720 struct xdp_buff *xdp,
4721 struct bpf_prog *xdp_prog)
4722 {
4723 void *orig_data, *orig_data_end, *hard_start;
4724 struct netdev_rx_queue *rxqueue;
4725 u32 metalen, act = XDP_DROP;
4726 bool orig_bcast, orig_host;
4727 u32 mac_len, frame_sz;
4728 __be16 orig_eth_type;
4729 struct ethhdr *eth;
4730 int off;
4731
4732 /* Reinjected packets coming from act_mirred or similar should
4733 * not get XDP generic processing.
4734 */
4735 if (skb_is_redirected(skb))
4736 return XDP_PASS;
4737
4738 /* XDP packets must be linear and must have sufficient headroom
4739 * of XDP_PACKET_HEADROOM bytes. This is the guarantee that also
4740 * native XDP provides, thus we need to do it here as well.
4741 */
4742 if (skb_cloned(skb) || skb_is_nonlinear(skb) ||
4743 skb_headroom(skb) < XDP_PACKET_HEADROOM) {
4744 int hroom = XDP_PACKET_HEADROOM - skb_headroom(skb);
4745 int troom = skb->tail + skb->data_len - skb->end;
4746
4747 /* In case we have to go down the path and also linearize,
4748 * then lets do the pskb_expand_head() work just once here.
4749 */
4750 if (pskb_expand_head(skb,
4751 hroom > 0 ? ALIGN(hroom, NET_SKB_PAD) : 0,
4752 troom > 0 ? troom + 128 : 0, GFP_ATOMIC))
4753 goto do_drop;
4754 if (skb_linearize(skb))
4755 goto do_drop;
4756 }
4757
4758 /* The XDP program wants to see the packet starting at the MAC
4759 * header.
4760 */
4761 mac_len = skb->data - skb_mac_header(skb);
4762 hard_start = skb->data - skb_headroom(skb);
4763
4764 /* SKB "head" area always have tailroom for skb_shared_info */
4765 frame_sz = (void *)skb_end_pointer(skb) - hard_start;
4766 frame_sz += SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
4767
4768 rxqueue = netif_get_rxqueue(skb);
4769 xdp_init_buff(xdp, frame_sz, &rxqueue->xdp_rxq);
4770 xdp_prepare_buff(xdp, hard_start, skb_headroom(skb) - mac_len,
4771 skb_headlen(skb) + mac_len, true);
4772
4773 orig_data_end = xdp->data_end;
4774 orig_data = xdp->data;
4775 eth = (struct ethhdr *)xdp->data;
> 4776 orig_host = ether_addr_equal_64bits(eth->h_dest, skb->dev->dev_addr);
4777 orig_bcast = is_multicast_ether_addr_64bits(eth->h_dest);
4778 orig_eth_type = eth->h_proto;
4779
4780 act = bpf_prog_run_xdp(xdp_prog, xdp);
4781
4782 /* check if bpf_xdp_adjust_head was used */
4783 off = xdp->data - orig_data;
4784 if (off) {
4785 if (off > 0)
4786 __skb_pull(skb, off);
4787 else if (off < 0)
4788 __skb_push(skb, -off);
4789
4790 skb->mac_header += off;
4791 skb_reset_network_header(skb);
4792 }
4793
4794 /* check if bpf_xdp_adjust_tail was used */
4795 off = xdp->data_end - orig_data_end;
4796 if (off != 0) {
4797 skb_set_tail_pointer(skb, xdp->data_end - xdp->data);
4798 skb->len += off; /* positive on grow, negative on shrink */
4799 }
4800
4801 /* check if XDP changed eth hdr such SKB needs update */
4802 eth = (struct ethhdr *)xdp->data;
4803 if ((orig_eth_type != eth->h_proto) ||
4804 (orig_host != ether_addr_equal_64bits(eth->h_dest,
4805 skb->dev->dev_addr)) ||
4806 (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) {
4807 __skb_push(skb, ETH_HLEN);
4808 skb->pkt_type = PACKET_HOST;
4809 skb->protocol = eth_type_trans(skb, skb->dev);
4810 }
4811
4812 switch (act) {
4813 case XDP_REDIRECT:
4814 case XDP_TX:
4815 __skb_push(skb, mac_len);
4816 break;
4817 case XDP_PASS:
4818 metalen = xdp->data - xdp->data_meta;
4819 if (metalen)
4820 skb_metadata_set(skb, metalen);
4821 break;
4822 default:
4823 bpf_warn_invalid_xdp_action(act);
4824 fallthrough;
4825 case XDP_ABORTED:
4826 trace_xdp_exception(skb->dev, xdp_prog, act);
4827 fallthrough;
4828 case XDP_DROP:
4829 do_drop:
4830 kfree_skb(skb);
4831 break;
4832 }
4833
4834 return act;
4835 }
4836
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-04-07 3:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-07 3:56 net/core/dev.c:4776:21: warning: 'ether_addr_equal_64bits' reading 8 bytes from a region of size 6 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®