mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7
@ 2026-04-09  3:43 Oliver White
  2026-05-19 14:45 ` Ilpo Järvinen
  0 siblings, 1 reply; 2+ messages in thread
From: Oliver White @ 2026-04-09  3:43 UTC (permalink / raw)
  To: luzmaximilian, hansg, ilpo.jarvinen
  Cc: platform-driver-x86, linux-kernel, Oliver White

Surface Laptop 7 exposes battery and AC status via Qualcomm PMIC GLINK
qcom_battmgr. Registering the standard SSAM battery and AC client
devices on this platform causes duplicate power-supply devices to
appear.

Drop the SSAM battery and AC nodes from the Surface Laptop 7 registry
group so that only the qcom_battmgr power supplies are instantiated.

Fixes: b27622f13172 ("platform/surface: Add OF support")
Signed-off-by: Oliver White <oliverjwhite07@gmail.com>
---
 drivers/platform/surface/surface_aggregator_registry.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c
index 0599d5adf02e..f0881edfb616 100644
--- a/drivers/platform/surface/surface_aggregator_registry.c
+++ b/drivers/platform/surface/surface_aggregator_registry.c
@@ -295,8 +295,6 @@ static const struct software_node *ssam_node_group_sl6[] = {
 /* Devices for Surface Laptop 7. */
 static const struct software_node *ssam_node_group_sl7[] = {
 	&ssam_node_root,
-	&ssam_node_bat_ac,
-	&ssam_node_bat_main,
 	&ssam_node_tmp_perf_profile_with_fan,
 	&ssam_node_fan_speed,
 	&ssam_node_hid_sam_keyboard,
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7
  2026-04-09  3:43 [PATCH] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7 Oliver White
@ 2026-05-19 14:45 ` Ilpo Järvinen
  0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2026-05-19 14:45 UTC (permalink / raw)
  To: luzmaximilian, hansg, Oliver White; +Cc: platform-driver-x86, linux-kernel

On Thu, 09 Apr 2026 15:43:47 +1200, Oliver White wrote:

> Surface Laptop 7 exposes battery and AC status via Qualcomm PMIC GLINK
> qcom_battmgr. Registering the standard SSAM battery and AC client
> devices on this platform causes duplicate power-supply devices to
> appear.
> 
> Drop the SSAM battery and AC nodes from the Surface Laptop 7 registry
> group so that only the qcom_battmgr power supplies are instantiated.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7
      commit: 0488073a6c84571dd3cffe581a4a73a5fceb099d

--
 i.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-19 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-09  3:43 [PATCH] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7 Oliver White
2026-05-19 14:45 ` Ilpo Järvinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®