* [PATCH] drm: Remove unused header in drm_dumb_buffers.c
@ 2026-04-09 15:48 Yicong Hui
2026-05-25 7:00 ` Yicong Sito Hui
2026-05-26 10:47 ` Thomas Zimmermann
0 siblings, 2 replies; 3+ messages in thread
From: Yicong Hui @ 2026-04-09 15:48 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann
Cc: dri-devel, linux-kernel, skhan, me, Yicong Hui
Remove the header #include "drm_internal.h" from drm_dumb_buffers.c,
which is included but not used.
Header was introduced in 47f10854ca89 when moving functions, but was
not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was
removed.
Compiles successfully with DRM enabled, pass kunit tests and
IGT-tests in a vng virtual machine.
Fixes: 96a7b60f6ddb ("drm: remove dumb_destroy callback")
Signed-off-by: Yicong Hui <yiconghui@gmail.com>
---
drivers/gpu/drm/drm_dumb_buffers.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c
index e2b62e5fb891..61bf3c9b7182 100644
--- a/drivers/gpu/drm/drm_dumb_buffers.c
+++ b/drivers/gpu/drm/drm_dumb_buffers.c
@@ -32,7 +32,6 @@
#include <drm/drm_print.h>
#include "drm_crtc_internal.h"
-#include "drm_internal.h"
/**
* DOC: overview
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Remove unused header in drm_dumb_buffers.c
2026-04-09 15:48 [PATCH] drm: Remove unused header in drm_dumb_buffers.c Yicong Hui
@ 2026-05-25 7:00 ` Yicong Sito Hui
2026-05-26 10:47 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Yicong Sito Hui @ 2026-05-25 7:00 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, simona,
alexdeucher, christian.koenig
Cc: dri-devel, linux-kernel, skhan, me
On 09/04/2026 4:48 pm, Yicong Hui wrote:
> Remove the header #include "drm_internal.h" from drm_dumb_buffers.c,
> which is included but not used.
>
> Header was introduced in 47f10854ca89 when moving functions, but was
> not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was
> removed.
>
> Compiles successfully with DRM enabled, pass kunit tests and
> IGT-tests in a vng virtual machine.
>
> Fixes: 96a7b60f6ddb ("drm: remove dumb_destroy callback")
> Signed-off-by: Yicong Hui <yiconghui@gmail.com>
> ---
> drivers/gpu/drm/drm_dumb_buffers.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c
> index e2b62e5fb891..61bf3c9b7182 100644
> --- a/drivers/gpu/drm/drm_dumb_buffers.c
> +++ b/drivers/gpu/drm/drm_dumb_buffers.c
> @@ -32,7 +32,6 @@
> #include <drm/drm_print.h>
>
> #include "drm_crtc_internal.h"
> -#include "drm_internal.h"
>
> /**
> * DOC: overview
Hello!
Is there any further feedback or progress on this patch?
Thank you!
Yicong
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Remove unused header in drm_dumb_buffers.c
2026-04-09 15:48 [PATCH] drm: Remove unused header in drm_dumb_buffers.c Yicong Hui
2026-05-25 7:00 ` Yicong Sito Hui
@ 2026-05-26 10:47 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2026-05-26 10:47 UTC (permalink / raw)
To: Yicong Hui, maarten.lankhorst, mripard; +Cc: dri-devel, linux-kernel, skhan, me
Hi,
sorry for the delay.
Am 09.04.26 um 17:48 schrieb Yicong Hui:
> Remove the header #include "drm_internal.h" from drm_dumb_buffers.c,
> which is included but not used.
>
> Header was introduced in 47f10854ca89 when moving functions, but was
> not removed in 96a7b60f6ddb when the drm_gem_dumb_destroy function was
> removed.
>
> Compiles successfully with DRM enabled, pass kunit tests and
> IGT-tests in a vng virtual machine.
>
> Fixes: 96a7b60f6ddb ("drm: remove dumb_destroy callback")
> Signed-off-by: Yicong Hui <yiconghui@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/drm_dumb_buffers.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c
> index e2b62e5fb891..61bf3c9b7182 100644
> --- a/drivers/gpu/drm/drm_dumb_buffers.c
> +++ b/drivers/gpu/drm/drm_dumb_buffers.c
> @@ -32,7 +32,6 @@
> #include <drm/drm_print.h>
>
> #include "drm_crtc_internal.h"
> -#include "drm_internal.h"
>
> /**
> * DOC: overview
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-26 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-09 15:48 [PATCH] drm: Remove unused header in drm_dumb_buffers.c Yicong Hui
2026-05-25 7:00 ` Yicong Sito Hui
2026-05-26 10:47 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®