mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Leech <cleech@redhat.com>
To: Daniel Wagner <wagi@kernel.org>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	 Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
	linux-nvme@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] nvme: expose TLS mode
Date: Fri, 10 Apr 2026 13:29:51 -0700	[thread overview]
Message-ID: <20260410-a7837a6847c8f98c51c89739@redhat.com> (raw)
In-Reply-To: <20260408-expose-tls-mode-v3-1-b869da028eff@kernel.org>

On Wed, Apr 08, 2026 at 06:19:56PM +0200, Daniel Wagner wrote:
> It is not possible to determine the active TLS mode from the
> presence or absence of sysfs attributes like tls_key,
> tls_configured_key, or dhchap_secret.
> 
> With the introduction of the concat mode and optional DH-CHAP
> authentication, different configurations can result in identical
> sysfs state. This makes user space detection unreliable.
> 
> Expose the TLS mode explicitly to allow user space to
> unambiguously identify the active configuration and avoid
> fragile heuristics in nvme-cli.
> 
> Signed-off-by: Daniel Wagner <wagi@kernel.org>

Looks good, I look forward to 'nvme config --scan --dump' being able to
get these configurations correct.  Thanks Daniel.

Reviewed-by: Chris Leech <cleech@redhat.com>


  parent reply	other threads:[~2026-04-10 20:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 16:19 Daniel Wagner
2026-04-09  6:32 ` Christoph Hellwig
2026-04-10 20:29 ` Chris Leech [this message]
2026-04-13  7:43 ` Hannes Reinecke
2026-04-16 22:07 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410-a7837a6847c8f98c51c89739@redhat.com \
    --to=cleech@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=wagi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®