* [PATCH] nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export
@ 2026-04-16 16:10 Jeff Layton
2026-04-16 17:09 ` Chuck Lever
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2026-04-16 16:10 UTC (permalink / raw)
To: Chuck Lever, NeilBrown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: linux-nfs, linux-kernel, llvm, Anna Schumaker, Jeff Layton
Anna was seeing these warnings with a clang W=1 build:
Warning: fs/nfsd/export.c:845 Cannot find identifier on line:
@cd: cache_detail for the svc_export cache,
Warning: fs/nfsd/export.c:846 Cannot find identifier on line:
@attr: nested attribute containing svc-export fields,
Warning: fs/nfsd/export.c:847 Cannot find identifier on line:
*
Warning: fs/nfsd/export.c:848 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
Fixes: 9d2c4bbf7435 ("nfsd: add netlink upcall for the svc_export cache")
Reported-by: Anna Schumaker <anna@kernel.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Trivial doc fix. Feel free to fold into the Fixes patch if you get this
before the sending the PR to Linus.
---
fs/nfsd/export.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index f562d383439b..99959cecdbbd 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -843,6 +843,7 @@ static int check_export(const struct path *path, int *flags,
unsigned char *uuid);
/**
+ * nfsd_nl_parse_one_export - parse a svc_export entry from a netlink downcall
* @cd: cache_detail for the svc_export cache
* @attr: nested attribute containing svc-export fields
*
---
base-commit: 07a9f86d6ee1a0dc3bac47e9819ec5269d01a603
change-id: 20260416-nfsd-doc-564f058f6f88
Best regards,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export
2026-04-16 16:10 [PATCH] nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export Jeff Layton
@ 2026-04-16 17:09 ` Chuck Lever
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever @ 2026-04-16 17:09 UTC (permalink / raw)
To: NeilBrown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Jeff Layton
Cc: Chuck Lever, linux-nfs, linux-kernel, llvm, Anna Schumaker
From: Chuck Lever <chuck.lever@oracle.com>
On Thu, 16 Apr 2026 09:10:00 -0700, Jeff Layton wrote:
> Anna was seeing these warnings with a clang W=1 build:
>
> Warning: fs/nfsd/export.c:845 Cannot find identifier on line:
>
> @cd: cache_detail for the svc_export cache,
> Warning: fs/nfsd/export.c:846 Cannot find identifier on line:
>
> [...]
Applied to nfsd-testing, thanks!
[1/1] nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export
(no commit info)
--
Chuck Lever <chuck.lever@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-16 17:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-16 16:10 [PATCH] nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export Jeff Layton
2026-04-16 17:09 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®