* [PATCH] drm/bridge/cdns-mhdp8546: Fix incorrect register clear in j721e disable
@ 2026-04-16 4:09 Udit Kumar
2026-04-22 19:44 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Udit Kumar @ 2026-04-16 4:09 UTC (permalink / raw)
To: andrzej.hajda, vigneshr, b-padhi, devarsht, y-d, neil.armstrong,
rfoss, yamonkar, sjakhade
Cc: Laurent.pinchart, jonas, jernej.skrabec, maarten.lankhorst,
mripard, tzimmermann, airlied, simona, dri-devel, linux-kernel,
Udit Kumar, stable
Fix the cdns_mhdp_j721e_disable() function to clear the correct register.
The function should clear DPTX_SRC_CFG (video source configuration) instead
of DPTX_DSC_CFG (DSC configuration) when disabling the display interface.
Clearing DPTX_SRC_CFG properly resets all video source settings (VIF enable
bits and DPI selections) to their default state.
Cc: stable@vger.kernel.org
Fixes: afba7e6c5fc19 ("drm: bridge: cdns-mhdp8546: Add TI J721E wrapper")
Signed-off-by: Udit Kumar <u-kumar1@ti.com>
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c
index 12d04be4e242..5f92436ffa0a 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c
@@ -62,7 +62,7 @@ static void cdns_mhdp_j721e_enable(struct cdns_mhdp_device *mhdp)
static void cdns_mhdp_j721e_disable(struct cdns_mhdp_device *mhdp)
{
/* Put everything to defaults */
- writel(0, mhdp->j721e_regs + DPTX_DSC_CFG);
+ writel(0, mhdp->j721e_regs + DPTX_SRC_CFG);
}
const struct mhdp_platform_ops mhdp_ti_j721e_ops = {
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge/cdns-mhdp8546: Fix incorrect register clear in j721e disable
2026-04-16 4:09 [PATCH] drm/bridge/cdns-mhdp8546: Fix incorrect register clear in j721e disable Udit Kumar
@ 2026-04-22 19:44 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2026-04-22 19:44 UTC (permalink / raw)
To: Udit Kumar
Cc: andrzej.hajda, vigneshr, b-padhi, devarsht, y-d, neil.armstrong,
rfoss, yamonkar, sjakhade, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, dri-devel, linux-kernel, stable
On Thu, Apr 16, 2026 at 09:39:33AM +0530, Udit Kumar wrote:
> Fix the cdns_mhdp_j721e_disable() function to clear the correct register.
> The function should clear DPTX_SRC_CFG (video source configuration) instead
> of DPTX_DSC_CFG (DSC configuration) when disabling the display interface.
>
> Clearing DPTX_SRC_CFG properly resets all video source settings (VIF enable
> bits and DPI selections) to their default state.
>
> Cc: stable@vger.kernel.org
> Fixes: afba7e6c5fc19 ("drm: bridge: cdns-mhdp8546: Add TI J721E wrapper")
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
> ---
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-22 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-16 4:09 [PATCH] drm/bridge/cdns-mhdp8546: Fix incorrect register clear in j721e disable Udit Kumar
2026-04-22 19:44 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®