mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/3] vfio/cdx: Fix interrupt trigger races and consolidate MSI state
@ 2026-04-17 20:27 Alex Williamson
  2026-04-17 20:27 ` [PATCH v2 1/3] vfio/cdx: Fix NULL pointer dereference in interrupt trigger path Alex Williamson
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Alex Williamson @ 2026-04-17 20:27 UTC (permalink / raw)
  To: alex
  Cc: Alex Williamson, ptsm, nipun.gupta, nikhil.agarwal, kvm, linux-kernel

Prasanna Kumar's original patch [1] closes a NULL-pointer dereference
that can be triggered by userspace via VFIO_DEVICE_SET_IRQS with
VFIO_IRQ_SET_DATA_BOOL or VFIO_IRQ_SET_DATA_NONE before any
VFIO_IRQ_SET_DATA_EVENTFD.  Included here unchanged as patch 1/3.

Review of that patch identified a race in the same code path, where
concurrent SET_IRQS calls can potentially result in time-of-check vs
time-of-use and use-after-free inconsistencies.  Patch 2/3 adds a
per-device cdx_irqs_lock mutex and serializes all MSI state updates
through vfio_cdx_set_msi_trigger(), which is the single choke-point
covering both the ioctl path and the close-device cleanup.

Patch 3/3 is a non-stable cleanup that aligns vdev->cdx_irqs to NULL
in error paths, thereby allowing removal of the now redundant
config_msi.

[1] https://lore.kernel.org/all/20260320101933.1554416-1-ptsm@linux.microsoft.com

Alex Williamson (2):
  vfio/cdx: Serialize VFIO_DEVICE_SET_IRQS with a per-device mutex
  vfio/cdx: Consolidate MSI configured state onto cdx_irqs

Prasanna Kumar T S M (1):
  vfio/cdx: Fix NULL pointer dereference in interrupt trigger path

 drivers/vfio/cdx/intr.c    | 38 ++++++++++++++++++--------------------
 drivers/vfio/cdx/main.c    | 19 +++++++++++++++++++
 drivers/vfio/cdx/private.h |  4 +++-
 3 files changed, 40 insertions(+), 21 deletions(-)

-- 
2.51.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-04-21 11:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-17 20:27 [PATCH v2 0/3] vfio/cdx: Fix interrupt trigger races and consolidate MSI state Alex Williamson
2026-04-17 20:27 ` [PATCH v2 1/3] vfio/cdx: Fix NULL pointer dereference in interrupt trigger path Alex Williamson
2026-04-17 20:27 ` [PATCH v2 2/3] vfio/cdx: Serialize VFIO_DEVICE_SET_IRQS with a per-device mutex Alex Williamson
2026-04-17 20:27 ` [PATCH v2 3/3] vfio/cdx: Consolidate MSI configured state onto cdx_irqs Alex Williamson
2026-04-21 11:27 ` [PATCH v2 0/3] vfio/cdx: Fix interrupt trigger races and consolidate MSI state Agarwal, Nikhil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®