mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
@ 2026-04-24 11:59 Mohamed Ayman
  2026-04-24 20:38 ` Linus Walleij
  2026-04-27  7:42 ` Bartosz Golaszewski
  0 siblings, 2 replies; 3+ messages in thread
From: Mohamed Ayman @ 2026-04-24 11:59 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM, open list
  Cc: Mohamed Ayman, open list:GPIO SUBSYSTEM, open list

Replace the temporary fallback handle_simple_irq with handle_bad_irq
now that the driver operates with a proper hierarchical IRQ setup.
This ensures unexpected or unmapped interrupts are clearly flagged
instead of being silently handled.

Signed-off-by: Mohamed Ayman <mohamedaymanworkspace@gmail.com>
---
 drivers/gpio/gpio-ep93xx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 1f56e44ffc9a..8784e433e1ff 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -323,8 +323,7 @@ static int ep93xx_setup_irqs(struct platform_device *pdev,
 	}
 
 	girq->default_type = IRQ_TYPE_NONE;
-	/* TODO: replace with handle_bad_irq() once we are fully hierarchical */
-	girq->handler = handle_simple_irq;
+	girq->handler = handle_bad_irq;
 
 	return 0;
 }
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
  2026-04-24 11:59 [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler Mohamed Ayman
@ 2026-04-24 20:38 ` Linus Walleij
  2026-04-27  7:42 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2026-04-24 20:38 UTC (permalink / raw)
  To: Mohamed Ayman; +Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM, open list

On Fri, Apr 24, 2026 at 1:59 PM Mohamed Ayman
<mohamedaymanworkspace@gmail.com> wrote:

> Replace the temporary fallback handle_simple_irq with handle_bad_irq
> now that the driver operates with a proper hierarchical IRQ setup.
> This ensures unexpected or unmapped interrupts are clearly flagged
> instead of being silently handled.
>
> Signed-off-by: Mohamed Ayman <mohamedaymanworkspace@gmail.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
  2026-04-24 11:59 [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler Mohamed Ayman
  2026-04-24 20:38 ` Linus Walleij
@ 2026-04-27  7:42 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-04-27  7:42 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel,
	Mohamed Ayman
  Cc: Bartosz Golaszewski


On Fri, 24 Apr 2026 14:59:20 +0300, Mohamed Ayman wrote:
> Replace the temporary fallback handle_simple_irq with handle_bad_irq
> now that the driver operates with a proper hierarchical IRQ setup.
> This ensures unexpected or unmapped interrupts are clearly flagged
> instead of being silently handled.
> 
> 

Applied, thanks!

[1/1] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
      https://git.kernel.org/brgl/c/42509588db15100732f236b6a007f384dde3833f

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-27  7:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-24 11:59 [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler Mohamed Ayman
2026-04-24 20:38 ` Linus Walleij
2026-04-27  7:42 ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®