* [PATCH v2] md: skip redundant raid_disks update when value is unchanged
@ 2026-04-28 13:05 Abd-Alrhman Masalkhi
2026-05-20 12:45 ` Yu Kuai
0 siblings, 1 reply; 2+ messages in thread
From: Abd-Alrhman Masalkhi @ 2026-04-28 13:05 UTC (permalink / raw)
To: song, yukuai; +Cc: linux-raid, linux-kernel, Abd-Alrhman Masalkhi
Calling update_raid_disks() with the same value as the current one
can trigger unnecessary work. For example, RAID1 will reallocate
resources such as the mempool for r1bio.
Signed-off-by: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
---
drivers/md/md.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index ac71640ff3a8..21b8ad17685f 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -4409,9 +4409,10 @@ raid_disks_store(struct mddev *mddev, const char *buf, size_t len)
err = mddev_suspend_and_lock(mddev);
if (err)
return err;
- if (mddev->pers)
- err = update_raid_disks(mddev, n);
- else if (mddev->reshape_position != MaxSector) {
+ if (mddev->pers) {
+ if (n != mddev->raid_disks)
+ err = update_raid_disks(mddev, n);
+ } else if (mddev->reshape_position != MaxSector) {
struct md_rdev *rdev;
int olddisks = mddev->raid_disks - mddev->delta_disks;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] md: skip redundant raid_disks update when value is unchanged
2026-04-28 13:05 [PATCH v2] md: skip redundant raid_disks update when value is unchanged Abd-Alrhman Masalkhi
@ 2026-05-20 12:45 ` Yu Kuai
0 siblings, 0 replies; 2+ messages in thread
From: Yu Kuai @ 2026-05-20 12:45 UTC (permalink / raw)
To: Abd-Alrhman Masalkhi, song, yukuai; +Cc: linux-raid, linux-kernel
在 2026/4/28 21:05, Abd-Alrhman Masalkhi 写道:
> Calling update_raid_disks() with the same value as the current one
> can trigger unnecessary work. For example, RAID1 will reallocate
> resources such as the mempool for r1bio.
>
> Signed-off-by: Abd-Alrhman Masalkhi<abd.masalkhi@gmail.com>
> ---
> drivers/md/md.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied to md-7.2
--
Thansk,
Kuai
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-20 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-28 13:05 [PATCH v2] md: skip redundant raid_disks update when value is unchanged Abd-Alrhman Masalkhi
2026-05-20 12:45 ` Yu Kuai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®