* [PATCH v2] media: i2c: alvium: Fix: correct typo in alvium_set_ctrl_auto_exposure
@ 2026-05-05 7:26 Martin Hecht
2026-05-22 10:40 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Martin Hecht @ 2026-05-05 7:26 UTC (permalink / raw)
Cc: sakari.ailus, martin.hecht, michael.roeder, stable, Martin Hecht,
Tommaso Merciai, Mauro Carvalho Chehab, Hans Verkuil,
linux-media, linux-kernel
write value for auto-exposure into register REG_BCRM_EXPOSURE_AUTO_RW
instead of wrong register REG_BCRM_WHITE_BALANCE_AUTO_RW.
Fixes: 0a7af872915e ("media: i2c: Add support for alvium camera")
Signed-off-by: Martin Hecht <mhecht73@gmail.com>
---
drivers/media/i2c/alvium-csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c
index 955b7072a560..b62b45a4f2fc 100644
--- a/drivers/media/i2c/alvium-csi2.c
+++ b/drivers/media/i2c/alvium-csi2.c
@@ -1290,7 +1290,7 @@ static int alvium_set_ctrl_auto_exposure(struct alvium_dev *alvium, bool on)
struct device *dev = &alvium->i2c_client->dev;
int ret;
- ret = alvium_write_hshake(alvium, REG_BCRM_WHITE_BALANCE_AUTO_RW,
+ ret = alvium_write_hshake(alvium, REG_BCRM_EXPOSURE_AUTO_RW,
on ? 0x02 : 0x00);
if (ret) {
dev_err(dev, "Fail to set autoexposure reg\n");
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] media: i2c: alvium: Fix: correct typo in alvium_set_ctrl_auto_exposure
2026-05-05 7:26 [PATCH v2] media: i2c: alvium: Fix: correct typo in alvium_set_ctrl_auto_exposure Martin Hecht
@ 2026-05-22 10:40 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2026-05-22 10:40 UTC (permalink / raw)
To: Martin Hecht
Cc: martin.hecht, michael.roeder, stable, Tommaso Merciai,
Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel
Hi Martin,
Considering the subject, I think it looks like more than a typo: the wrong
register gets written here before the patch. I think it'd be reasonable to
say that.
On Tue, May 05, 2026 at 09:26:52AM +0200, Martin Hecht wrote:
> write value for auto-exposure into register REG_BCRM_EXPOSURE_AUTO_RW
> instead of wrong register REG_BCRM_WHITE_BALANCE_AUTO_RW.
The sententence should begin with a capital letter.
>
> Fixes: 0a7af872915e ("media: i2c: Add support for alvium camera")
> Signed-off-by: Martin Hecht <mhecht73@gmail.com>
Cc: stable..., please.
> ---
> drivers/media/i2c/alvium-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c
> index 955b7072a560..b62b45a4f2fc 100644
> --- a/drivers/media/i2c/alvium-csi2.c
> +++ b/drivers/media/i2c/alvium-csi2.c
> @@ -1290,7 +1290,7 @@ static int alvium_set_ctrl_auto_exposure(struct alvium_dev *alvium, bool on)
> struct device *dev = &alvium->i2c_client->dev;
> int ret;
>
> - ret = alvium_write_hshake(alvium, REG_BCRM_WHITE_BALANCE_AUTO_RW,
> + ret = alvium_write_hshake(alvium, REG_BCRM_EXPOSURE_AUTO_RW,
> on ? 0x02 : 0x00);
> if (ret) {
> dev_err(dev, "Fail to set autoexposure reg\n");
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-22 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-05 7:26 [PATCH v2] media: i2c: alvium: Fix: correct typo in alvium_set_ctrl_auto_exposure Martin Hecht
2026-05-22 10:40 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®